Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acquisition: receipt detail view & refactoring #751

Merged
merged 1 commit into from Dec 1, 2021

Conversation

zannkukai
Copy link
Contributor

Adds a component to display all details about a receipt.
Refactors acquisition modules services : removes generic services to
keep only API services ; removes all unnecessary classes in favor of
corresponding interfaces (lighter for memory usage).

Co-authored-by: Renaud Michotte renaud.michotte@gmail.com

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@github-actions github-actions bot added f: acquisitions Related to the acquisition module f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface labels Nov 22, 2021
@zannkukai zannkukai force-pushed the zan-receipt-detail-view branch 2 times, most recently from 88f995a to 0b9e269 Compare November 22, 2021 15:42
@zannkukai zannkukai force-pushed the zan-receipt-detail-view branch 2 times, most recently from 28e3810 to 27f4f2d Compare December 1, 2021 13:00
@zannkukai zannkukai self-assigned this Dec 1, 2021
* Adds a component to display all details about a receipt.
* Refactors acquisition modules services : removes generic services to
  keep only API services ; removes all unnecessary classes in favor of
  corresponding interfaces (lighter for memory usage).
* Adapts accounting informations display.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai merged commit 6781182 into rero:US_acquisition Dec 1, 2021
@zannkukai zannkukai deleted the zan-receipt-detail-view branch December 1, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: acquisitions Related to the acquisition module f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants