Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Holdings should be grouped by libraries #1399

Closed
pronguen opened this issue Nov 5, 2020 · 2 comments · Fixed by #1541
Closed

Holdings should be grouped by libraries #1399

pronguen opened this issue Nov 5, 2020 · 2 comments · Fixed by #1541
Assignees
@Garfield-fr
Labels
enhancement Improvement of an existing feature f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface p-Medium Medium priority (to be solved within 1-2 years)
Projects
Milestone v1.0.0
Milestone
v1.0.0

Comments

@pronguen
Copy link
Contributor

pronguen commented Nov 5, 2020 •
edited

How it works

Holdings are not grouped by library. See screenshot.

Improvement suggestion

They should be grouped by libraries. Concerns the public AND pro interface. In general: they are sorted alphabetically (name of library, name of location).

Nice to have:

  • In the pro interface, holdings of the librarian login library are displayed first.
  • In the public interface, holdings of the patron affiliation library are displayed first.
  • In the global public interface, holdings of the patron affiliation library are displayed first, holdings of the patron organisation are displayed 2nd, other holdings are displayed then.

Context

Proposed by pilot libraries
Tested on ilspilot.test.rero.ch (v0.12.0)

Screenshots

image
@pronguen pronguen added enhancement Improvement of an existing feature triage labels Nov 5, 2020
@iGormilhit
Copy link

@pronguen A small precision: which order for the public interface when no user is logged in? By library name alphabetical order? By number of items?

@iGormilhit iGormilhit added f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface p-Low Low priority and removed triage labels Nov 19, 2020
@pronguen
Copy link
Contributor Author

@pronguen A small precision: which order for the public interface when no user is logged in? By library name alphabetical order? By number of items?

I completed the main text of the issue... alphabetically. I don't see any other logic. Future: by location of the library in comparison to the location of the anonymous user (closest first)!

@pronguen pronguen added p-Medium Medium priority (to be solved within 1-2 years) and removed p-Low Low priority labels Nov 19, 2020
@iGormilhit iGormilhit added this to the v1.0.0 milestone Nov 30, 2020
@iGormilhit iGormilhit added this to To do in Milestone v1.0.0 Dec 2, 2020
@Garfield-fr Garfield-fr self-assigned this Dec 3, 2020
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Dec 3, 2020
@Garfield-fr
document: holdings should be grouped by libraries
1a4d683 
The layout of the book type no longer shows the holdings structure.
The buttons have been aligned on the vertical after the data.

* closes rero#1399

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr mentioned this issue Dec 3, 2020
Merged
7 tasks
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Dec 3, 2020
@Garfield-fr
document: holdings should be grouped by libraries
4ad90d9 
* closes rero/rero-ils#1399

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Dec 3, 2020
@Garfield-fr
document: holdings should be grouped by libraries
f343264 
The layout of the book type no longer shows the holdings structure.
The buttons have been aligned on the vertical after the data.

* closes rero#1399

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Dec 3, 2020
@Garfield-fr
document: holdings should be grouped by libraries
22bcf7e 
The layout of the book type no longer shows the holdings structure.
The buttons have been aligned on the vertical after the data.

* closes rero#1399

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Dec 9, 2020
@Garfield-fr
document: holdings should be grouped by libraries
0ffb45b 
The layout of the book type no longer shows the holdings structure.
The buttons have been aligned on the vertical after the data.

* closes rero#1399

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Dec 9, 2020
@Garfield-fr
document: holdings should be grouped by libraries
f6ac0a6 
The layout of the book type no longer shows the holdings structure.
The buttons have been aligned on the vertical after the data.

* closes rero#1399

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Dec 10, 2020
@Garfield-fr
document: holdings should be grouped by libraries
8d708a7 
The layout of the book type no longer shows the holdings structure.
The buttons have been aligned on the vertical after the data.

* closes rero#1399

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Dec 10, 2020
@Garfield-fr
document: holdings should be grouped by libraries
6cb2d6e 
The layout of the book type no longer shows the holdings structure.
The buttons have been aligned on the vertical after the data.

* closes rero#1399

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Dec 11, 2020
@Garfield-fr
document: holdings should be grouped by libraries
eb87cbd 
The layout of the book type no longer shows the holdings structure.
The buttons have been aligned on the vertical after the data.

* closes rero#1399

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Dec 11, 2020
@Garfield-fr
document: holdings should be grouped by libraries
c153c6e 
* closes rero/rero-ils#1399

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Dec 14, 2020
@Garfield-fr
documents: group holdings by libraries
0287cc3 
The layout of the book type no longer shows the holdings structure.
The buttons have been aligned on the vertical after the data.

* closes rero#1399

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Dec 14, 2020
@Garfield-fr
documents: group holdings by libraries
e37ff37 
* closes rero/rero-ils#1399

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Dec 14, 2020
@Garfield-fr
documents: group holdings by libraries
a25f6c1 
The layout of the book type no longer shows the holdings structure.
The buttons have been aligned vertically below the data.

* Closes rero#1399.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Dec 14, 2020
@Garfield-fr
documents: group holdings by libraries
8cdbbcf 
* Closes rero/rero-ils#1399

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Dec 14, 2020
@Garfield-fr
documents: group holdings by libraries
bff91ee 
The layout of the book type no longer shows the holdings structure.
The buttons have been aligned vertically below the data.

* Closes rero#1399.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Dec 14, 2020
@Garfield-fr
documents: group holdings by libraries
4ba63b7 
The layout of the book type no longer shows the holdings structure.
The buttons have been aligned vertically below the data.

* Closes rero#1399.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Dec 14, 2020
@Garfield-fr
documents: group holdings by libraries
540c3c0 
The layout of the book type no longer shows the holdings structure.
The buttons have been aligned vertically below the data.

* Fixes parent $ref title on local fields schema.
* Closes rero#1399.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Dec 14, 2020
@Garfield-fr
documents: group holdings by libraries
7a47e4e 
The layout of the book type no longer shows the holdings structure.
The buttons have been aligned vertically below the data.

* Fixes parent $ref title on local fields schema.
* Closes rero#1399.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Dec 14, 2020
@Garfield-fr
documents: group holdings by libraries
8ef9251 
The layout of the book type no longer shows the holdings structure.
The buttons have been aligned vertically below the data.

* Fixes parent $ref title on local fields schema.
* Closes rero#1399.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Dec 14, 2020
@Garfield-fr
documents: group holdings by libraries
846aa11 
The layout of the book type no longer shows the holdings structure.
The buttons have been aligned vertically below the data.

* Fixes parent $ref title on local fields schema.
* Fixes enumeration and chronology on document detail view.
* Closes rero#1399.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Milestone v1.0.0 automation moved this from To do to Done Dec 15, 2020
Garfield-fr added a commit that referenced this issue Dec 15, 2020
@Garfield-fr
documents: group holdings by libraries
6492e80 
The layout of the book type no longer shows the holdings structure.
The buttons have been aligned vertically below the data.

* Fixes parent $ref title on local fields schema.
* Fixes enumeration and chronology on document detail view.
* Closes #1399.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
enhancement Improvement of an existing feature f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface p-Medium Medium priority (to be solved within 1-2 years)
Projects
No open projects
Milestone v1.0.0
Done
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

documents: group holdings by libraries Garfield-fr/rero-ils
3 participants
@Garfield-fr @iGormilhit @pronguen