Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ILL requests: 'copy' field is not correctly saved #1671

Closed
ManaDeweerdt opened this issue Feb 3, 2021 · 2 comments · Fixed by #3324
Closed

ILL requests: 'copy' field is not correctly saved #1671

ManaDeweerdt opened this issue Feb 3, 2021 · 2 comments · Fixed by #3324
Labels
bug Breaks something but is not blocking f: public ui Public interface, as opposed to the professional interface f: user management p-Low Low priority

Comments

@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Feb 3, 2021 •
edited

Describe the bug

In the user profile of the public interface, the scope of the ILL requests is always set to 'loan' even if we have chosen 'copy'.
Additionaly, there is no pagination information.
We have the same issue in the professional interface.

To Reproduce

  1. Login as a user.
  2. Create an ILL request and chose the scope 'copy'. Add pagination.
  3. Check the scope of the ILL request in the profile.

Expected behavior

The right scope should be displayed.
@ManaDeweerdt ManaDeweerdt added triage bug Breaks something but is not blocking p-Low Low priority labels Feb 3, 2021
@iGormilhit iGormilhit added f: public ui Public interface, as opposed to the professional interface f: user management and removed triage labels Feb 4, 2021
@iGormilhit
Copy link

This is fixed in v1.2.0 (tested on ilsdev).

@PascalRepond
Copy link
Contributor

This is still the case v1.15.0

@PascalRepond PascalRepond reopened this May 3, 2023
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue May 3, 2023
@PascalRepond
ill requests: fix forms
f11d0de 
* Fixes pickup location filter in pro UI.
* Fixes incorrect patron form field "copy".
* Closes rero#1671.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
@PascalRepond PascalRepond mentioned this issue May 3, 2023
Merged
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue May 3, 2023
@PascalRepond
ill requests: fix forms
1ab6c4e 
* Fixes pickup location filter in pro UI.
* Fixes incorrect patron form field "copy".
* Closes rero#1671.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue May 3, 2023
@PascalRepond
ill requests: fix forms
e56f233 
* Fixes pickup location filter in pro UI.
* Fixes incorrect patron form field "copy".
* Closes rero#1671.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
@PascalRepond PascalRepond changed the title ILL requests: scope is always set to 'copy' ILL requests: 'copy' field is not correctly saved May 4, 2023
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue May 4, 2023
@PascalRepond
ill requests: fix forms
122f5de 
* Fixes pickup location filter in pro UI.
* Fixes incorrect patron form field "copy".
* Closes rero#1671.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue May 8, 2023
@PascalRepond
ill requests: fix forms
843ddff 
* Fixes pickup location filter in pro UI.
* Fixes incorrect patron form field "copy".
* Closes rero#1671.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit that referenced this issue May 8, 2023
@PascalRepond
ill requests: fix forms
de40028 
* Fixes pickup location filter in pro UI.
* Fixes incorrect patron form field "copy".
* Closes #1671.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Breaks something but is not blocking f: public ui Public interface, as opposed to the professional interface f: user management p-Low Low priority
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ill requests: fix forms PascalRepond/rero-ils
3 participants
@iGormilhit @ManaDeweerdt @PascalRepond