Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edition: performance #1747

Closed
ManaDeweerdt opened this issue Mar 4, 2021 · 1 comment · Fixed by rero/ng-core#446
Closed

Edition: performance #1747

ManaDeweerdt opened this issue Mar 4, 2021 · 1 comment · Fixed by rero/ng-core#446
Labels
enhancement Improvement of an existing feature f: editor Concerns editor based on JSON schema AND custom editor p-High High priority (to be solved in the 2-3 next months) performance

Comments

@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Mar 4, 2021 •
edited
Loading

How it works

When we edit/create a record or import a new record, it takes a few seconds before the page loads.

Improvement suggestion

The load of the editor should be faster.
@ManaDeweerdt ManaDeweerdt added enhancement Improvement of an existing feature triage p-Medium Medium priority (to be solved within 1-2 years) labels Mar 4, 2021
@ManaDeweerdt ManaDeweerdt changed the title Edition: perfomance Edition: performance Mar 5, 2021
@JoelleDosimont
Copy link
Contributor

Some examples when editing a record :
https://ils.test.rero.ch/professional/records/documents/edit/1600589
https://ils.test.rero.ch/professional/records/documents/edit/134
https://ils.test.rero.ch/professional/records/documents/edit/835

@iGormilhit iGormilhit added performance f: editor Concerns editor based on JSON schema AND custom editor and removed triage labels Apr 26, 2021
@pronguen pronguen added p-High High priority (to be solved in the 2-3 next months) and removed UCL Libraries p-Medium Medium priority (to be solved within 1-2 years) labels Aug 25, 2021
jma added a commit to jma/ng-core that referenced this issue Sep 8, 2021
@jma
editor: speed up the editor
1a788cd 
* Reduces the resource and the time to load the editor.
* Adds a new method to set the list of the hidden fields.
* Removes the bad use of `setTimeout`.
* Adds scroll to suggestion list.
* Closes rero/rero-ils#1747.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma mentioned this issue Sep 8, 2021
Merged
7 tasks
jma added a commit to jma/ng-core that referenced this issue Sep 8, 2021
@jma
editor: speed up the editor
5ee9301 
* Reduces the resource and the time to load the editor.
* Adds a new method to set the list of the hidden fields.
* Removes the bad use of `setTimeout`.
* Adds scroll to suggestion list.
* Closes rero/rero-ils#1747.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/ng-core that referenced this issue Sep 8, 2021
@jma
editor: speed up the editor
a558fa3 
* Reduces the resource and the time to load the editor.
* Adds a new method to set the list of the hidden fields.
* Removes the bad use of `setTimeout`.
* Adds scroll to suggestion list.
* Closes rero/rero-ils#1747.
* Closes rero/rero-ils#1908.
* Fixes autocomplete external link UI.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/ng-core that referenced this issue Sep 8, 2021
@jma
editor: speed up the editor
edac58f 
* Reduces the resource and the time to load the editor.
* Adds a new method to set the list of the hidden fields.
* Removes the bad use of `setTimeout`.
* Adds scroll to suggestion list.
* Closes rero/rero-ils#1747.
* Closes rero/rero-ils#1908.
* Fixes autocomplete external link UI.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to rero/ng-core that referenced this issue Sep 9, 2021
@jma
editor: speed up the editor
19fa440 
* Reduces the resource and the time to load the editor.
* Adds a new method to set the list of the hidden fields.
* Removes the bad use of `setTimeout`.
* Adds scroll to suggestion list.
* Closes rero/rero-ils#1747.
* Closes rero/rero-ils#1908.
* Fixes autocomplete external link UI.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement of an existing feature f: editor Concerns editor based on JSON schema AND custom editor p-High High priority (to be solved in the 2-3 next months) performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

editor: speed up the editor jma/ng-core
4 participants
@iGormilhit @pronguen @ManaDeweerdt @JoelleDosimont