Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit document field subject (is newly implemented) #1869

Closed
pronguen opened this issue May 3, 2021 · 0 comments · Fixed by #2808
Closed

Edit document field subject (is newly implemented) #1869

pronguen opened this issue May 3, 2021 · 0 comments · Fixed by #2808
Assignees
@zannkukai
Labels
correction An implemented feature doesn't work as expected. f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface p-Medium Medium priority (to be solved within 1-2 years)

Comments

@pronguen
Copy link
Contributor

pronguen commented May 3, 2021 •
edited

How it works

The field subjects is not displayed correctly, as its JSON structure has been reworked.

How it should works

The display of subjects is replaced by the new subjects in the document detailed view (public + pro):
* preferred_name
* title / creator
* term
* the subject type is displayed as tooltip
@pronguen pronguen added f: data About data model, importation, transformation, exportation of data, specific for bibliographic data correction p-Medium Medium priority (to be solved within 1-2 years) labels May 3, 2021
@iGormilhit iGormilhit added f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface labels Jun 1, 2021
@PascalRepond PascalRepond added bug Breaks something but is not blocking and removed class: correction labels Feb 21, 2022
@PascalRepond PascalRepond added correction An implemented feature doesn't work as expected. and removed bug Breaks something but is not blocking labels Mar 14, 2022
@ManaDeweerdt ManaDeweerdt mentioned this issue Mar 31, 2022
Closed
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 1, 2022
@zannkukai
document: subjects subdivision
8efee14 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes rero#2455.
Closes rero#2609.
Closes rero#1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Apr 1, 2022
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 1, 2022
@zannkukai
document: subjects subdivision
bc9106d 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes rero#2455.
Closes rero#2609.
Closes rero#1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 2, 2022
@zannkukai
document: subjects subdivision
5d661a2 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes rero#2455.
Closes rero#2609.
Closes rero#1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 3, 2022
@zannkukai
document: subjects subdivision
f5cf1f1 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes rero#2455.
Closes rero#2609.
Closes rero#1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 3, 2022
@zannkukai
document: subjects subdivision
662c757 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes rero#2455.
Closes rero#2609.
Closes rero#1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue Apr 21, 2022
@zannkukai
document: subjects subdivision
69c25c2 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes #2455.
Closes #2609.
Closes #1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue Apr 21, 2022
@zannkukai
document: subjects subdivision
80a2b04 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes #2455.
Closes #2609.
Closes #1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 28, 2022
@zannkukai
document: subjects subdivision
7f83925 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes rero#2455.
Closes rero#2609.
Closes rero#1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 28, 2022
@zannkukai
document: subjects subdivision
5de77fe 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes rero#2455.
Closes rero#2609.
Closes rero#1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 28, 2022
@zannkukai
document: subjects subdivision
3462b98 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes rero#2455.
Closes rero#2609.
Closes rero#1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue May 4, 2022
@zannkukai
document: subjects subdivision
a90b917 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes #2455.
Closes #2609.
Closes #1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 4, 2022
@zannkukai
document: subjects subdivision
dbb0d26 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes rero#2455.
Closes rero#2609.
Closes rero#1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 5, 2022
@zannkukai
document: subjects subdivision
ad2241f 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes rero#2455.
Closes rero#2609.
Closes rero#1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 5, 2022
@zannkukai
document: subjects subdivision
22aef53 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes rero#2455.
Closes rero#2609.
Closes rero#1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue May 5, 2022
@zannkukai
document: subjects subdivision
5c1e1b5 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes #2455.
Closes #2609.
Closes #1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 6, 2022
@zannkukai
document: subjects subdivision
15ea7d1 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes rero#2455.
Closes rero#2609.
Closes rero#1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue May 9, 2022
@zannkukai
document: subjects subdivision
9fcf2e9 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes #2455.
Closes #2609.
Closes #1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
correction An implemented feature doesn't work as expected. f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

document: subjects subdivision zannkukai/rero-ils
4 participants
@iGormilhit @pronguen @zannkukai @PascalRepond