Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to compile public-holdings-items UI project #2172

Closed
zannkukai opened this issue Jul 15, 2021 · 0 comments · Fixed by rero/rero-ils-ui#671
Closed

Unable to compile public-holdings-items UI project #2172

zannkukai opened this issue Jul 15, 2021 · 0 comments · Fixed by rero/rero-ils-ui#671
Labels
bug Breaks something but is not blocking dev: dependencies Related to a dependency that needs to be fixed, or pinned, or changed developers From a developer point of view. p-High High priority (to be solved in the 2-3 next months)

Comments

@zannkukai
Copy link
Contributor

zannkukai commented Jul 15, 2021 •
edited by iGormilhit

Describe the bug

When we tried to compile the UI project public-holdings-items, an error occurred.
It is now impossible to work/correct this project.

To Reproduce

  1. Go to rero/dev branch of the rero-ils-ui project.
  2. npm ci
  3. npm run start-public-holdings-items-proxy
  4. See error.
git fetch -p --all
git checkout dev
git reset --hard rero/dev
git push -f

npm ci  --> OK
ng build shared (ou ng build --project shared) --> OK
npm run start-public-holdings-items-proxy --> Error: Maximum call stack size exceeded

Additional infos

It seems to be a dependencies problem.
When we use the rero/rero-ils-ui@e671bb8 commit, the compilation succeed.
The next commit update dependencies, and compilation failed.

Expected behavior

Compilation should succeed.

Context

  • server: localhost
  • version: rero-ils-ui v0.16.5

Screenshots

image
image
@zannkukai zannkukai added triage bug Breaks something but is not blocking labels Jul 15, 2021
@iGormilhit iGormilhit added dev: dependencies Related to a dependency that needs to be fixed, or pinned, or changed developers From a developer point of view. p-High High priority (to be solved in the 2-3 next months) and removed triage labels Jul 19, 2021
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Jul 20, 2021
@zannkukai
documents: optimize holdings/items display
0beef38 
* Loads/displays more holding by default (10). Collapse holdings panels if
  there are more than 1 holdings to display.
* Loads/displays more items by default (10).
* Fixes linting of `public-search` project.
* Harmonizes public/professional document view.
* Closes rero/rero-ils#2134.
* Closes rero/rero-ils#2133.
* Closes rero/rero-ils#2172.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Jul 20, 2021
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Jul 20, 2021
@zannkukai
documents: optimize holdings/items display
bddc129 
* Loads/displays more holding by default (10). Collapse holdings panels if
  there are more than 1 holdings to display.
* Loads/displays more items by default (10).
* Fixes linting of `public-search` project.
* Harmonizes public/professional document view.
* Closes rero/rero-ils#2134.
* Closes rero/rero-ils#2133.
* Closes rero/rero-ils#2172.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
iGormilhit pushed a commit to rero/rero-ils-ui that referenced this issue Jul 20, 2021
@zannkukai
documents: optimize holdings/items display
bd6e0d6 
* Loads/displays more holding by default (10). Collapse holdings panels if
  there are more than 1 holdings to display.
* Loads/displays more items by default (10).
* Fixes linting of `public-search` project.
* Harmonizes public/professional document view.
* Closes rero/rero-ils#2134.
* Closes rero/rero-ils#2133.
* Closes rero/rero-ils#2172.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Breaks something but is not blocking dev: dependencies Related to a dependency that needs to be fixed, or pinned, or changed developers From a developer point of view. p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

documents: optimize holdings/items display zannkukai/rero-ils-ui
2 participants
@iGormilhit @zannkukai