Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong default value of subject.source and genreForm.source #2212

Closed
pronguen opened this issue Jul 20, 2021 · 1 comment · Fixed by #2233
Closed

Wrong default value of subject.source and genreForm.source #2212

pronguen opened this issue Jul 20, 2021 · 1 comment · Fixed by #2233
Assignees
@zannkukai
Labels
effort: minor Solved quickly f: editor Concerns editor based on JSON schema AND custom editor p-Medium Medium priority (to be solved within 1-2 years)
Milestone
v1.5.0

Comments

@pronguen
Copy link
Contributor

pronguen commented Jul 20, 2021 •
edited

How it works

When adding a subject (local entity) or a genre/form with a source, there is a default value of the source in the editor ("Factum" for subject, "rero" for genreForm).

How it should works

There should be no default value.
@pronguen pronguen added effort: minor Solved quickly f: editor Concerns editor based on JSON schema AND custom editor correction p-Medium Medium priority (to be solved within 1-2 years) labels Jul 20, 2021
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Jul 22, 2021
@zannkukai
document: no default value for subject.source
b88cb68 
Closes rero#2212.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Jul 22, 2021
Merged
7 tasks
@zannkukai zannkukai self-assigned this Jul 22, 2021
@zannkukai zannkukai added this to the v1.5.0 milestone Jul 22, 2021
@pronguen pronguen changed the title "factum" as wrong default value of subject.source Wrong default value of subject.source and genreForm.source Jul 26, 2021
@pronguen
Copy link
Contributor Author

@zannkukai I modified this issue before seeing that it was already solved. Should I create another issue or can you expand your correction to field genreForm.source?

pronguen pushed a commit that referenced this issue Aug 11, 2021
@zannkukai @pronguen
document: no default value for subject.source
e832a7b 
Closes #2212.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@pronguen pronguen mentioned this issue Aug 17, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
effort: minor Solved quickly f: editor Concerns editor based on JSON schema AND custom editor p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging a pull request may close this issue.

document: no default value for subject.source zannkukai/rero-ils
2 participants
@pronguen @zannkukai