Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft records accessible in public view cause Internal Server errors #2623

Closed
rerowep opened this issue Dec 30, 2021 · 0 comments · Fixed by #2818
Closed

Draft records accessible in public view cause Internal Server errors #2623

rerowep opened this issue Dec 30, 2021 · 0 comments · Fixed by #2818
Labels
bug Breaks something but is not blocking dev: sentry For PRs that are created to correct an error raised by Sentry. f: public ui Public interface, as opposed to the professional interface p-Low Low priority p-Medium Medium priority (to be solved within 1-2 years)

Comments

@rerowep
Copy link
Contributor

rerowep commented Dec 30, 2021 •
edited by PascalRepond

How it works

Sentry raises an internal server error if someone tries to load a record with _draft:true in the public UI because the document doesn't return a type. See Sentry error ID RERO-ILS-163.

Following draft record has no type: https://bib.rero.ch/global/documents/2090554

Improvement suggestion

It is very unlikely that someone tries to load a draft record in the public UI. This error is thus of very low priority.
@rerowep rerowep added triage bug Breaks something but is not blocking labels Dec 30, 2021
@PascalRepond PascalRepond changed the title Draft records in public view Draft records accessible in public view cause Internal Server errors Feb 11, 2022
@PascalRepond PascalRepond added the f: public ui Public interface, as opposed to the professional interface label Feb 11, 2022
@PascalRepond PascalRepond added dev: monitoring Alert system like Sentry or Zabbix. p-Medium Medium priority (to be solved within 1-2 years) labels Mar 18, 2022
@ManaDeweerdt ManaDeweerdt mentioned this issue Apr 4, 2022
Closed
@PascalRepond PascalRepond added dev: sentry For PRs that are created to correct an error raised by Sentry. p-Low Low priority and removed dev: monitoring Alert system like Sentry or Zabbix. labels Apr 4, 2022
@PascalRepond PascalRepond mentioned this issue Apr 6, 2022
Merged
7 tasks
rerowep added a commit to rerowep/rero-ils that referenced this issue Apr 6, 2022
@rerowep
documents: draft view
7fb85e7 
* Allows display of drafts without type.
* Closes rero#2623.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep added a commit to rerowep/rero-ils that referenced this issue Apr 6, 2022
@rerowep
documents: draft view
412591c 
* Allows display of drafts without type.
* Closes rero#2623.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep added a commit to rerowep/rero-ils that referenced this issue Apr 7, 2022
@rerowep
documents: draft view
ad8d90a 
* Allows display of drafts without type.
* Closes rero#2623.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep added a commit to rerowep/rero-ils that referenced this issue Apr 11, 2022
@rerowep
documents: draft view
0a51980 
* Allows display of drafts without type.
* Closes rero#2623.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep added a commit that referenced this issue Apr 13, 2022
@rerowep
documents: draft view
9718db1 
* Allows display of drafts without type.
* Closes #2623.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Breaks something but is not blocking dev: sentry For PRs that are created to correct an error raised by Sentry. f: public ui Public interface, as opposed to the professional interface p-Low Low priority p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

documents: draft view rerowep/rero-ils
2 participants
@rerowep @PascalRepond