Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation error 'multiple of 0.01' at the receipt #2815

Closed
2 tasks
ManaDeweerdt opened this issue Apr 5, 2022 · 0 comments · Fixed by #2829
Closed
2 tasks

Validation error 'multiple of 0.01' at the receipt #2815

ManaDeweerdt opened this issue Apr 5, 2022 · 0 comments · Fixed by #2829
Assignees
@zannkukai
Labels
bug Breaks something but is not blocking f: acquisitions Related to the acquisition module f: professional ui Professional interface p-Medium Medium priority (to be solved within 1-2 years)
Milestone
v1.11.0

Comments

@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Apr 5, 2022 •
edited

Bug description:

Sometimes, we get an error message when we try to save an amount in the receipt editor. Ex: 4.01 is not a multiple of 0.01.

Note: similar to #2602

Expected behavior:

Any amount should be saved.

Steps to Reproduce:

Context

Server:

Version:

v1.9.0 ; commit hash : XXXX

Browser:

Chrome, Safari, Firefox; version XX

Screenshots

image.png
@ManaDeweerdt ManaDeweerdt added bug Breaks something but is not blocking f: acquisitions Related to the acquisition module f: professional ui Professional interface p-Medium Medium priority (to be solved within 1-2 years) labels Apr 5, 2022
@ManaDeweerdt ManaDeweerdt changed the title Validation error 'multiple of 0.01' at the reception Validation error 'multiple of 0.01' at the receipt Apr 5, 2022
@zannkukai zannkukai self-assigned this Apr 7, 2022
@zannkukai zannkukai added this to the v1.11.0 milestone Apr 7, 2022
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 11, 2022
@zannkukai
extension: improve maximum decimal extension
81dd313 
* Allows to specify a callback function to get resource values to check.
* Improves maximum decimal detection method. The "rounding" method used
  was not working for value '1.0000003' or '2.99999997'.
* Closes rero#2815.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Apr 11, 2022
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 11, 2022
@zannkukai
extension: improve maximum decimal extension
82a8924 
* Allows to specify a callback function to get resource values to check.
* Improves maximum decimal detection method. The "rounding" method used
  was not working for value '1.0000003' or '2.99999997'.
* Closes rero#2815.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 28, 2022
@zannkukai
extension: improve maximum decimal extension
72781f3 
* Allows to specify a callback function to get resource values to check.
* Improves maximum decimal detection method. The "rounding" method used
  was not working for value '1.0000003' or '2.99999997'.
* Closes rero#2815.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue May 4, 2022
@zannkukai
extension: improve maximum decimal extension
0e64b21 
* Allows to specify a callback function to get resource values to check.
* Improves maximum decimal detection method. The "rounding" method used
  was not working for value '1.0000003' or '2.99999997'.
* Closes #2815.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
bug Breaks something but is not blocking f: acquisitions Related to the acquisition module f: professional ui Professional interface p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
v1.11.0
Development

Successfully merging a pull request may close this issue.

extension: improve maximum decimal extension zannkukai/rero-ils
2 participants
@zannkukai @ManaDeweerdt