Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account name and number: duplicate should not be validated #2817

Closed
pronguen opened this issue Apr 5, 2022 · 1 comment · Fixed by #2871
Closed

Account name and number: duplicate should not be validated #2817

pronguen opened this issue Apr 5, 2022 · 1 comment · Fixed by #2871
Assignees
@Garfield-fr
Labels
correction An implemented feature doesn't work as expected. f: acquisitions Related to the acquisition module f: editor Concerns editor based on JSON schema AND custom editor p-Medium Medium priority (to be solved within 1-2 years)

Comments

@pronguen
Copy link
Contributor

pronguen commented Apr 5, 2022 •
edited

How it works

The acquisition account name and number are validated against duplicates. But the validation is done within the instance. Consequence: two libraries within two different organisation cannot have two accounts with the same name.

Following message appears:

name and/or number value(s) already taken by pid=22.

Improvement suggestion

No validation is done for the two fields name and number.
@pronguen pronguen added correction An implemented feature doesn't work as expected. f: editor Concerns editor based on JSON schema AND custom editor f: acquisitions Related to the acquisition module p-Medium Medium priority (to be solved within 1-2 years) labels Apr 5, 2022
@pronguen
Copy link
Contributor Author

Previously, the expected behaviour was:

For the two fields name and number, the duplicate validation is done only

  • within the same library library
  • within the same budget budget

We decided to remove the validation during the grooming, because this feature is used in principle only once a year and it is quite easy for the librarian to verify the account name/number.

Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue May 3, 2022
@Garfield-fr
acquisition account: remove validation on fields
36323be 
* Removes validation on name and number fields.
* Closes rero#2817.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr self-assigned this May 3, 2022
@Garfield-fr Garfield-fr mentioned this issue May 3, 2022
Merged
7 tasks
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue May 3, 2022
@Garfield-fr
acquisition account: remove validation on fields
b89265a 
* Removes validation on name and number fields.
* Closes rero#2817.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit that referenced this issue May 3, 2022
@Garfield-fr
acquisition account: remove validation on fields
f7944e0 
* Removes validation on name and number fields.
* Closes #2817.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@PascalRepond PascalRepond changed the title Account name and number: duplicate should be validated only within library and fiscal year Account name and number: duplicate should not be validated May 3, 2022
Garfield-fr added a commit that referenced this issue May 4, 2022
@Garfield-fr
acquisition account: remove validation on fields
4660cb6 
* Removes validation on name and number fields.
* Closes #2817.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
correction An implemented feature doesn't work as expected. f: acquisitions Related to the acquisition module f: editor Concerns editor based on JSON schema AND custom editor p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

acquisition account: remove validation on fields Garfield-fr/rero-ils
2 participants
@Garfield-fr @pronguen