Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong fixtures for the organisation active budgets #2850

Closed
pronguen opened this issue Apr 26, 2022 · 0 comments · Fixed by #2852
Closed

Wrong fixtures for the organisation active budgets #2850

pronguen opened this issue Apr 26, 2022 · 0 comments · Fixed by #2852
Assignees
@BadrAly
Labels
bug Breaks something but is not blocking dev: fixtures Fixtures data used for ils.test and ilsdev.test f: acquisitions Related to the acquisition module

Comments

@pronguen
Copy link
Contributor

pronguen commented Apr 26, 2022 •
edited

Bug description:

In the organisation fixtures, field current_budget_pid refers to budgets that don't exist.

It is then impossible to add accounts.

Expected behavior:

It is possible to add an account when logged in at organisation.pid:3 (fictive).

TO DO

  • Organisation fixtures are corrected (every organisation has one budget)
  • Ideally, every library (especially in the fictive organisation pid:3)
    • has one acq_account attached
    • has the acquisition delivery information (field acquisition_settings.shipping_informations in the library resource)

Version:

v1.10.0
@pronguen pronguen added bug Breaks something but is not blocking f: acquisitions Related to the acquisition module dev: fixtures Fixtures data used for ils.test and ilsdev.test labels Apr 26, 2022
@BadrAly BadrAly self-assigned this Apr 26, 2022
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Apr 26, 2022
fixtures: ensure better indexing of acqz data
baed728 
* Adds acquisition settings for all libraries.
* Adds acquisition accounts for all libraries.
* Fixes rero#2850

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@BadrAly BadrAly mentioned this issue Apr 26, 2022
Merged
7 tasks
BadrAly pushed a commit that referenced this issue Apr 26, 2022
fixtures: ensure better indexing of acqz data
25d09d9 
* Adds acquisition settings for all libraries.
* Adds acquisition accounts for all libraries.
* Fixes #2850

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
PascalRepond pushed a commit that referenced this issue Apr 28, 2022
@PascalRepond
fixtures: ensure better indexing of acqz data
bf85e9f 
* Adds acquisition settings for all libraries.
* Adds acquisition accounts for all libraries.
* Fixes #2850

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BadrAly BadrAly

Labels
bug Breaks something but is not blocking dev: fixtures Fixtures data used for ils.test and ilsdev.test f: acquisitions Related to the acquisition module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixtures: ensure better indexing of acqz data BadrAly/rero-ils
2 participants
@pronguen @BadrAly