Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect patron communication_channel after removing email. #2887

Closed
4 tasks done
BadrAly opened this issue May 9, 2022 · 0 comments · Fixed by #2889
Closed
4 tasks done

Incorrect patron communication_channel after removing email. #2887

BadrAly opened this issue May 9, 2022 · 0 comments · Fixed by #2889
Assignees
@BadrAly
Labels
bug Breaks something but is not blocking f: user management

Comments

@BadrAly
Copy link

BadrAly commented May 9, 2022

Bug description:

When a patron removes the email from his/her own profile via the public interface, the communication_channel remains set to email even though the patron has no additional_communication_email set.

Expected behavior:

The patron field communication_channel should be set to mail if it has no email configured for both fields email and additional_communication_email

Steps to Reproduce:

  1. Open a user profile in the public interface
  2. Remove the contents of the field email
  3. Save the profile
  4. Go to the professional interface and check there is no emails set in the field additional_communication_email
  5. The patron communication_channel is still set to email.

Server:

Version:
v1.10.0
@BadrAly BadrAly added f: user management bug Breaks something but is not blocking labels May 9, 2022
@BadrAly BadrAly self-assigned this May 9, 2022
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue May 9, 2022
notifications: not sent after patron changes
b321275 
No reset password notifications are sent after any changes made
to the patron/user record for both admin and public interfaces.

The communication channel is updated automatically after updates
made to the patron profile by the patron himself.

* Fixes rero#2313
* Fixes rero#2281
* Fixes rero#1580
* Fixes rero#2887

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@BadrAly BadrAly mentioned this issue May 9, 2022
Merged
7 tasks
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue May 9, 2022
notifications: not sent after patron changes
ee883ee 
No reset password notifications are sent after any changes made
to the patron/user record for both admin and public interfaces.

The communication channel is updated automatically after updates
made to the patron profile by the patron himself.

* Fixes rero#2313
* Fixes rero#2281
* Fixes rero#1580
* Fixes rero#2887

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue May 10, 2022
notifications: not sent after patron changes
a2ab214 
No reset password notifications are sent after any changes made
to the patron/user record for both admin and public interfaces.

The communication channel is updated automatically after updates
made to the patron profile by the patron himself.

* Fixes rero#2313
* Fixes rero#2281
* Fixes rero#1580
* Fixes rero#2887

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue May 10, 2022
notifications: not sent after patron changes
f4e31e0 
No reset password notifications are sent after any changes made
to the patron/user record for both admin and public interfaces.

The communication channel is updated automatically after updates
made to the patron profile by the patron himself.

* Fixes rero#2313
* Fixes rero#2281
* Fixes rero#1580
* Fixes rero#2887

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue May 10, 2022
notifications: not sent after patron changes
fca4e4f 
No reset password notifications are sent after any changes made
to the patron/user record for both admin and public interfaces.

The communication channel is updated automatically after updates
made to the patron profile by the patron himself.

* Fixes rero#2313
* Fixes rero#2281
* Fixes rero#1580
* Fixes rero#2887

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue May 10, 2022
notifications: not sent after patron changes
1796978 
No reset password notifications are sent after any changes made
to the patron/user record for both admin and public interfaces.

The communication channel is updated automatically after updates
made to the patron profile by the patron himself.

* Fixes rero#2313
* Fixes rero#2281
* Fixes rero#1580
* Fixes rero#2887

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit that referenced this issue May 10, 2022
notifications: not sent after patron changes
f8ff3b9 
No reset password notifications are sent after any changes made
to the patron/user record for both admin and public interfaces.

The communication channel is updated automatically after updates
made to the patron profile by the patron himself.

* Fixes #2313
* Fixes #2281
* Fixes #1580
* Fixes #2887

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit that referenced this issue May 12, 2022
notifications: not sent after patron changes
5d98826 
No reset password notifications are sent after any changes made
to the patron/user record for both admin and public interfaces.

The communication channel is updated automatically after updates
made to the patron profile by the patron himself.

* Fixes #2313
* Fixes #2281
* Fixes #1580
* Fixes #2887

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BadrAly BadrAly

Labels
bug Breaks something but is not blocking f: user management
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

notifications: not sent after patron changes BadrAly/rero-ils
1 participant
@BadrAly