Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notifications: store recipients for circulation notifications #3288

Closed
PascalRepond opened this issue Mar 27, 2023 · 0 comments · Fixed by #3293
Closed

notifications: store recipients for circulation notifications #3288

PascalRepond opened this issue Mar 27, 2023 · 0 comments · Fixed by #3293
Assignees
@zannkukai
Labels
enhancement Improvement of an existing feature f: notifications

Comments

@PascalRepond
Copy link
Contributor

PascalRepond commented Mar 27, 2023 •
edited

How it works

The field recipients in the notification is only used for acquisition notifs. It would be useful to also store this data for circulation notification for search purposes.

Improvement suggestion

  • When a circulation notification is processed and sent, the email address(es) where the notification was sent to are stored in the recipients list (db and index).
  • If data is already present (notification sent a second time), it is cleared and replaced by the new recipient.
@PascalRepond PascalRepond added enhancement Improvement of an existing feature f: notifications labels Mar 27, 2023
@PascalRepond PascalRepond changed the title notifications: store circ notification recipients notifications: store recipients for circulation notifications Mar 27, 2023
@zannkukai zannkukai self-assigned this Mar 30, 2023
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Mar 30, 2023
@zannkukai
notifications: add effective_recipients field.
949ee89 
* Adds new `effective_recipients` field into the `Notification`
  resource. This field will stored the recipients if the notification is
  successfully sent.
* Fixes rero#3288.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Mar 30, 2023
Merged
PascalRepond pushed a commit that referenced this issue Apr 4, 2023
@zannkukai @PascalRepond
notifications: add effective_recipients field.
0e3f6f4 
* Adds new `effective_recipients` field into the `Notification`
  resource. This field will stored the recipients if the notification is
  successfully sent.
* Fixes #3288.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
PascalRepond pushed a commit that referenced this issue Apr 5, 2023
@zannkukai @PascalRepond
notifications: add effective_recipients field.
0ade7fb 
* Adds new `effective_recipients` field into the `Notification`
  resource. This field will stored the recipients if the notification is
  successfully sent.
* Fixes #3288.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 12, 2023
@zannkukai
notifications: add effective_recipients field.
edf41de 
* Adds new `effective_recipients` field into the `Notification`
  resource. This field will stored the recipients if the notification is
  successfully sent.
* Fixes rero#3288.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue Apr 19, 2023
@zannkukai
notifications: add effective_recipients field.
48ae49f 
* Adds new `effective_recipients` field into the `Notification`
  resource. This field will stored the recipients if the notification is
  successfully sent.
* Fixes #3288.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
enhancement Improvement of an existing feature f: notifications
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

notifications: add effective_recipients field. zannkukai/rero-ils
2 participants
@zannkukai @PascalRepond