Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serials: sorting date is only used in the holding edit view #3295

Closed
PascalRepond opened this issue Mar 31, 2023 · 0 comments · Fixed by rero/rero-ils-ui#965
Closed

serials: sorting date is only used in the holding edit view #3295

PascalRepond opened this issue Mar 31, 2023 · 0 comments · Fixed by rero/rero-ils-ui#965
Assignees
@zannkukai
Labels
correction An implemented feature doesn't work as expected. f: serials

Comments

@PascalRepond
Copy link
Contributor

How it works

The issue-item field sorting_date is used to sort issues into a holding. However, it is only taken into account in the holdings' edit view in the pro UI.

image

Improvement suggestion

The sorting of items of type issues should consider the sorting date also in the holding detailed view (pro and public UI).
@PascalRepond PascalRepond added f: serials correction An implemented feature doesn't work as expected. labels Mar 31, 2023
@PascalRepond PascalRepond changed the title issues: sorting date is only used in the holding edit view serials: sorting date is only used in the holding edit view Mar 31, 2023
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Apr 3, 2023
@zannkukai
items: update default sort for serial holding to issue_sort_date
80f1fde 
* Fixes rero/rero-ils#3295.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai self-assigned this Apr 3, 2023
@zannkukai zannkukai mentioned this issue Apr 3, 2023
Merged
PascalRepond pushed a commit to rero/rero-ils-ui that referenced this issue Apr 4, 2023
@zannkukai @PascalRepond
items: update default sort for serial holding to issue_sort_date
d5b97f3 
* Fixes rero/rero-ils#3295.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
PascalRepond pushed a commit to rero/rero-ils-ui that referenced this issue Apr 5, 2023
@zannkukai @PascalRepond
items: update default sort for serial holding to issue_sort_date
b30bfbb 
* Fixes rero/rero-ils#3295.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
PascalRepond pushed a commit to rero/rero-ils-ui that referenced this issue Apr 5, 2023
@zannkukai @PascalRepond
items: update default sort for serial holding to issue_sort_date
04e6539 
* Fixes rero/rero-ils#3295.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Apr 20, 2023
@zannkukai
items: update default sort for serial holding to issue_sort_date
b6435e8 
* Fixes rero/rero-ils#3295.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to rero/rero-ils-ui that referenced this issue Apr 20, 2023
@zannkukai
items: update default sort for serial holding to issue_sort_date
8e136bb 
* Fixes rero/rero-ils#3295.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
correction An implemented feature doesn't work as expected. f: serials
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

items: update default sort for serial holding to issue_sort_date zannkukai/rero-ils-ui
2 participants
@zannkukai @PascalRepond