Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"online" item type in fixture #573

Closed
pronguen opened this issue Oct 21, 2019 · 0 comments
Closed

"online" item type in fixture #573

pronguen opened this issue Oct 21, 2019 · 0 comments
Assignees
@zannkukai
Labels
f: data About data model, importation, transformation, exportation of data, specific for bibliographic data

Comments

@pronguen
Copy link
Contributor

pronguen commented Oct 21, 2019 •
edited by iGormilhit

Describe the issue
Fixtures for physical item creation should not use item type "online".

To Reproduce

  1. Search a physical item (ie. with barcode) that has item type "online" (this search is not possible though the interface

Expected behavior
Physical items (in fixtures) should never have item type "online".

Screenshots
image
@iGormilhit iGormilhit added the f: data About data model, importation, transformation, exportation of data, specific for bibliographic data label Oct 23, 2019
@zannkukai zannkukai mentioned this issue Oct 24, 2019
Merged
6 tasks
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Oct 24, 2019
@zannkukai
items: fix online locations status
263309f 
* Fix `data/location.json` file : Add missing `is_online` tag when it's necessary
* Closes rero#573

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Oct 24, 2019
@zannkukai
items: fix online locations status
1dbf2e6 
* Fix `data/location.json` file : Removing not online location name `Online`
* Closes rero#573

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Oct 24, 2019
@zannkukai
items: fix online locations status
692c543 
* Fix `data/location.json` file : Add missing `is_online` tag when it's necessary
* Closes rero#573

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Oct 24, 2019
@zannkukai
items: fix online locations status
d181ee7 
* Fix `data/location.json` file : Removing not online location name `Online`
* Closes rero#573

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Oct 24, 2019
@zannkukai
items: fix online locations status
58fd5f4 
* Fix `data/location.json` file : Removing not online location name `Online`
* Closes rero#573

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Oct 24, 2019
@zannkukai
items: fix online locations status
9bd9e04 
* Fix `data/location.json` file : Removing not online location name `Online`
* Closes rero#573

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Oct 28, 2019
@zannkukai
items: fix online locations status
e7efa6c 
* Fix `data/location.json` file : Removing not online location name `Online`
* Closes rero#573

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai self-assigned this Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
f: data About data model, importation, transformation, exportation of data, specific for bibliographic data
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iGormilhit @pronguen @zannkukai