US1274: Import from BnF #1076
Merged
US1274: Import from BnF #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This classes helps to get records from external resources like BNF. It is possible to search for records and transform them into rero-ils json format without saving them to the database. The search result can be displayed and filtered. It is also possible to display the source data of an record and import the data into the database. * Adds general class for imports. * Adds BNF specific import class. * Saves the search result in REDIS `RERO_IMPORT_CACHE` = 'redis://localhost:6379/4' for expiering time of `RERO_IMPORT_CACHE_EXPIRE` = 10 minutes. * Adds argument `format` to the rest endpoints. Output mimetypes can now be spezified by argument or in the header of the request. Co-Authored-by: Peter Weber <peter.weber@rero.ch>
* Splits the document dumps function to be usable to the serializers. * Renames `/api/import/bnf` to `/api/import_bnf` to be usable by the UI. * Fixes year aggregation filter by forcing the terms to be a string. * Returns empty result for empty query. * Sorts aggregations by terms for year and by term counts and names for the other. * Creates a post_process function in JSON serializers. * Creates two serializers: one without extra data for the editor one with extra data for the document views. * Adds a new not found result error handler. * Makes the tests more robust to BNF changes. * Removes useless cli command. * Returns the number of results on the remote server. * Fixes empty record returned by the BNF. * Adds the number of records matching the query found on the remote server. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
BadrAly
approved these changes
Jul 2, 2020
Garfield-fr
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are you opening this PR?
Dependencies
My PR depends on the following
rero-ils-ui's PR(s):How to test?
Code review check list