New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patrons: manage patrons without e-mail #1418
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Makes the email optional. * Updates the fixtures. * Updates the user loading script. * Adds an additionnal notification email for the patron. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
* Adds a warning message to the user without email address. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
A system librarian should have all the librarian rights. * Removes the librarian role to the system librarian of Martigny in the test fixtures to test this specific case. * Closes #1340. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
* Uses patron permissions without http request. * Adds a custom invenio-accouts change password API to allow a librarian to change a password for a patron. * Makes the user_id in the patron jsonschema required. * Gives more weight on the barcode field for the patrons searches. * Fixes street description message in the patron JSONSchema, closes #1382. * Fixes email validation in the patron and vendore JSONSchema, closes #1381. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
iGormilhit
changed the title
Patrons without e-mail
patrons: manage patrons without e-mail
Nov 10, 2020
jma
force-pushed
the
maj-US1659-patron-without-email
branch
2 times, most recently
from
November 10, 2020 15:34
9f6cc5e
to
8cf8f02
Compare
jma
force-pushed
the
maj-US1659-patron-without-email
branch
3 times, most recently
from
November 12, 2020 07:35
2ad75f8
to
4c9ace1
Compare
* Renames `PidAlradyUsed` to `PidAlreadyUsed` exception. * Changes the email validation message in several resources. * Fixes update email value from the professional user editor. * Adds a `append` option to the user creation script. This force to increment the PID counter and avoid error for new patron creation. * Make the user email required when the librarian or system librarian role is enable. * Fixes details document information display in the ILL requests of the patron profile. Implements: https://tree.taiga.io/project/rero21-reroils/us/1659 Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma
force-pushed
the
maj-US1659-patron-without-email
branch
from
November 12, 2020 09:42
4c9ace1
to
26560eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are you opening this PR?
Dependencies
rero/rero-ils-ui#411
How to test?
street
field should not ask for a coma. #1382Fixes needed after the tests:
PidAlradyUsed
toPidAlreadyUsed
exception.append
option to the user creation script. This force toincrement the PID counter and avoid error for new patron creation.
role is enable.
patron profile.
Implements: https://tree.taiga.io/project/rero21-reroils/us/1659
Code review check list