Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patrons: manage patrons without e-mail #1418

Merged
merged 5 commits into from Nov 12, 2020
Merged

Conversation

jma
Copy link
Contributor

@jma jma commented Nov 9, 2020

Why are you opening this PR?

Dependencies

rero/rero-ils-ui#411

How to test?

Fixes needed after the tests:

  • Renames PidAlradyUsed to PidAlreadyUsed exception.
  • Changes the email validation message in several resources.
  • Fixes update email value from the professional user editor.
  • Adds a append option to the user creation script. This force to
    increment the PID counter and avoid error for new patron creation.
  • Make the user email required when the librarian or system librarian
    role is enable.
  • Fixes details document information display in the ILL requests of the
    patron profile.

Implements: https://tree.taiga.io/project/rero21-reroils/us/1659

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

* Makes the email optional.
* Updates the fixtures.
* Updates the user loading script.
* Adds an additionnal notification email for the patron.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
* Adds a warning message to the user without email address.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
A system librarian should have all the librarian rights.

* Removes the librarian role to the system librarian of Martigny in the
  test fixtures to test this specific case.
* Closes #1340.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
* Uses patron permissions without http request.
* Adds a custom invenio-accouts change password API to allow a librarian
  to change a password for a patron.
* Makes the user_id in the patron jsonschema required.
* Gives more weight on the barcode field for the patrons searches.
* Fixes street description message in the patron JSONSchema, closes #1382.
* Fixes email validation in the patron and vendore JSONSchema, closes #1381.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@iGormilhit iGormilhit changed the title Patrons without e-mail patrons: manage patrons without e-mail Nov 10, 2020
@pronguen
Copy link
Contributor

pronguen commented Nov 10, 2020

  • patron public account: the first ILL request cannot be expanded (stay collapsed). I don't know if it is linked to this PR.
    image
  • create users: not able to save a new user, it spins forever. Updating an existing user works!
  • create users: if the e-mail is required for librarian, is it possible to have a warning or a description text?
  • create users: a default expiration date should be set (current date + 3 years)
  • create users: the validation message for e-mails that don't match the pattern is too complex. It should be just "The e-mail is not valid."
    image
  • create users: when I remove the e-mail of a patron in the pro user resource, this patron can still login with this e-mail. When I replace it by another e-mail, the patron cannot login with the new one, but still with the old one. For info: when I change my e-mail in the RERO ID, this works!
  • checkin/checkout: in the checkin form, it spins forever when I search for a word that is only present in a non patron user (example: search for "astrid", search for "rodriguez"). This is not blocking.

@jma jma force-pushed the maj-US1659-patron-without-email branch 2 times, most recently from 9f6cc5e to 8cf8f02 Compare November 10, 2020 15:34
@iGormilhit iGormilhit added this to New in RERO ILS PRs via automation Nov 11, 2020
@iGormilhit iGormilhit moved this from New to PR for next release in RERO ILS PRs Nov 11, 2020
@iGormilhit iGormilhit added this to the v0.14.0 milestone Nov 11, 2020
@jma jma force-pushed the maj-US1659-patron-without-email branch 3 times, most recently from 2ad75f8 to 4c9ace1 Compare November 12, 2020 07:35
* Renames `PidAlradyUsed` to `PidAlreadyUsed` exception.
* Changes the email validation message in several resources.
* Fixes update email value from the professional user editor.
* Adds a `append` option to the user creation script. This force to
  increment the PID counter and avoid error for new patron creation.
* Make the user email required when the librarian or system librarian
  role is enable.
* Fixes details document information display in the ILL requests of the
  patron profile.

Implements: https://tree.taiga.io/project/rero21-reroils/us/1659

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma force-pushed the maj-US1659-patron-without-email branch from 4c9ace1 to 26560eb Compare November 12, 2020 09:42
@jma jma merged commit dc3caa5 into dev Nov 12, 2020
RERO ILS PRs automation moved this from PR for next release to Closed PR Nov 12, 2020
@jma jma deleted the maj-US1659-patron-without-email branch December 18, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
RERO ILS PRs
  
Closed PR
Development

Successfully merging this pull request may close these issues.

A system librarian without role librarian doesn't have all rights and has bugs
3 participants