public ui: fix missing library facet on org view #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Locally tested: the library facet works on every organisation view. |
iGormilhit
approved these changes
Jul 21, 2021
Garfield-fr
approved these changes
Jul 21, 2021
benerken
approved these changes
Jul 21, 2021
* Forces to compute the `organisation` aggregation values when the view is an organisation view and the `library` aggregation is enable. * Closes rero#2215. Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
jma
force-pushed
the
maj-fix-library-org-view-aggs
branch
from
b6e87cd
to
90e603d
Compare
rerowep
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
organisationaggregation values when the viewis an organisation view and the
libraryaggregation is enable.Co-Authored-by: Johnny Mariéthoz johnny.mariethoz@rero.ch
Why are you opening this PR?
Dependencies
My PR depends on the following
rero-ils-ui's PR(s):How to test?
Code review check list