notifications: support pickup location deletion #2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iGormilhit
suggested changes
Aug 30, 2021
rerowep
force-pushed
the
wep-#2254-fix-notification-with-deleted-pickup-location
branch
from
5c08373
to
536d991
Compare
rerowep
force-pushed
the
wep-#2254-fix-notification-with-deleted-pickup-location
branch
from
536d991
to
a20d9f7
Compare
zannkukai
approved these changes
Aug 30, 2021
rerowep
force-pushed
the
wep-#2254-fix-notification-with-deleted-pickup-location
branch
3 times, most recently
from
3bb904f
to
2a4de66
Compare
iGormilhit
changed the title
iGormilhit
approved these changes
Aug 31, 2021
rerowep
force-pushed
the
wep-#2254-fix-notification-with-deleted-pickup-location
branch
from
2a4de66
to
cd29aad
Compare
* Uses transaction location if pickup location does not exist any more. Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep
force-pushed
the
wep-#2254-fix-notification-with-deleted-pickup-location
branch
from
cd29aad
to
bb5ab79
Compare
benerken
approved these changes
Sep 1, 2021
lauren-d
approved these changes
Sep 1, 2021
BadrAly
approved these changes
Sep 1, 2021
rerowep
deleted the
wep-#2254-fix-notification-with-deleted-pickup-location
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Peter Weber peter.weber@rero.ch
Why are you opening this PR?
Dependencies
My PR depends on the following
rero-ils-ui's PR(s):How to test?
Code review check list