Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loans: handle loans without patrons #2347

Merged
merged 1 commit into from Sep 2, 2021
Merged

loans: handle loans without patrons #2347

merged 1 commit into from Sep 2, 2021

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Aug 31, 2021

  • Fixes the anonymization for loans with deleted patrons.

Co-Authored-by: Peter Weber peter.weber@rero.ch

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@rerowep rerowep self-assigned this Aug 31, 2021
@github-actions github-actions bot added the f: circulation Concerns the circulation interface or backend label Aug 31, 2021
@iGormilhit iGormilhit added this to New in RERO ILS PRs via automation Aug 31, 2021
@iGormilhit iGormilhit moved this from New to Fix on production in RERO ILS PRs Aug 31, 2021
@iGormilhit iGormilhit added this to the v1.4.9 milestone Aug 31, 2021
iGormilhit
iGormilhit suggested changes Aug 31, 2021
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message proposition:

loans: handle loans without patrons

* Prevents the failure of anonymization for loans with deleted patrons.

rero_ils/modules/loans/api.py Outdated Show resolved Hide resolved
@rerowep rerowep force-pushed the wep-#2256-fix-anonymizer-without-patron branch from dcaca34 to f831942 Compare August 31, 2021 09:21
@iGormilhit iGormilhit changed the title loans: Fix no patron for loan loans: handle loans without patrons Aug 31, 2021
iGormilhit
iGormilhit approved these changes Aug 31, 2021
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@rerowep rerowep force-pushed the wep-#2256-fix-anonymizer-without-patron branch from f831942 to 1d45f62 Compare August 31, 2021 10:17
@github-actions github-actions bot added the f: activity-logs Everything around logging user or system activities label Aug 31, 2021
@rerowep rerowep force-pushed the wep-#2256-fix-anonymizer-without-patron branch from 1d45f62 to d30a87d Compare August 31, 2021 12:04
@rerowep rerowep requested a review from jma August 31, 2021 12:06
@rerowep rerowep force-pushed the wep-#2256-fix-anonymizer-without-patron branch 5 times, most recently from b9dc2b0 to f7afa94 Compare September 1, 2021 09:23
@rerowep rerowep force-pushed the wep-#2256-fix-anonymizer-without-patron branch from f7afa94 to bf4fc57 Compare September 1, 2021 13:25
jma
jma approved these changes Sep 2, 2021
View reviewed changes
rero_ils/modules/loans/api.py Outdated Show resolved Hide resolved
rero_ils/modules/loans/api.py Outdated Show resolved Hide resolved
@rerowep rerowep force-pushed the wep-#2256-fix-anonymizer-without-patron branch from bf4fc57 to 56bf741 Compare September 2, 2021 06:41
@rerowep
loans: handle loans without patrons
35c7def 
* Prevents the failure of anonymization for loans with deleted patrons.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
@rerowep rerowep force-pushed the wep-#2256-fix-anonymizer-without-patron branch from 56bf741 to 35c7def Compare September 2, 2021 08:00
@iGormilhit iGormilhit merged commit 8251e2e into rero:dev Sep 2, 2021
RERO ILS PRs automation moved this from Fix on production to Closed PR Sep 2, 2021
@rerowep rerowep deleted the wep-#2256-fix-anonymizer-without-patron branch September 6, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jma jma jma approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

@benerken benerken benerken approved these changes

@BadrAly BadrAly BadrAly approved these changes

@zannkukai zannkukai Awaiting requested review from zannkukai

Assignees

@rerowep rerowep

Labels
f: activity-logs Everything around logging user or system activities f: circulation Concerns the circulation interface or backend f: user management
Projects
No open projects
RERO ILS PRs
  
Closed PR
Milestone
v1.4.9
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rerowep @jma @iGormilhit @zannkukai @benerken @BadrAly