Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

circulation: fix loan end_date #2435

Merged
merged 1 commit into from Oct 6, 2021
Merged

circulation: fix loan end_date #2435

merged 1 commit into from Oct 6, 2021

Conversation

zannkukai
Copy link
Contributor

Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@zannkukai
circulation: fix loan end_date
587a743 
* Closes rero#2198.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai added this to the v1.6.0 milestone Oct 4, 2021
@zannkukai zannkukai self-assigned this Oct 4, 2021
@zannkukai zannkukai added this to New in RERO ILS PRs via automation Oct 4, 2021
@github-actions github-actions bot added the f: circulation Concerns the circulation interface or backend label Oct 4, 2021
iGormilhit
iGormilhit approved these changes Oct 6, 2021
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@iGormilhit iGormilhit moved this from New to Fix on production in RERO ILS PRs Oct 6, 2021
@iGormilhit iGormilhit modified the milestones: v1.6.0, v1.5.1 Oct 6, 2021
@iGormilhit iGormilhit merged commit 1adeabd into rero:dev Oct 6, 2021
RERO ILS PRs automation moved this from Fix on production to Closed PR Oct 6, 2021
@zannkukai zannkukai deleted the zan-fix-issue-2198 branch October 7, 2021 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iGormilhit iGormilhit iGormilhit approved these changes

@BadrAly BadrAly BadrAly approved these changes

@lauren-d lauren-d lauren-d approved these changes

@benerken benerken Awaiting requested review from benerken

Assignees

@zannkukai zannkukai

Labels
f: circulation Concerns the circulation interface or backend
Projects
No open projects
RERO ILS PRs
  
Closed PR
Milestone
v1.5.1
Development

Successfully merging this pull request may close these issues.

Due date not computed correcty (also after renewal)
4 participants
@zannkukai @iGormilhit @BadrAly @lauren-d