Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup: fix setup script #2510

Merged
merged 1 commit into from
Nov 9, 2021
Merged

setup: fix setup script #2510

merged 1 commit into from
Nov 9, 2021

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Nov 9, 2021

  • Deletes --no-info from setup script.
  • Fixes flask-wtf dependency that cause an Working outside of request context
    error during user creation with version >= 1.0.0

Co-Authored-by: Peter Weber peter.weber@rero.ch

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

* Deletes --no-info from setup script.
* Fixes `flask-wtf` dependency that cause an `Working outside of request context`
  error during user creation with version >= 1.0.0

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
@rerowep rerowep self-assigned this Nov 9, 2021
@github-actions github-actions bot added the developers From a developer point of view. label Nov 9, 2021
@zannkukai zannkukai merged commit 5a00ad5 into rero:staging Nov 9, 2021
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@rerowep rerowep deleted the wep-fix-setup2 branch November 11, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developers From a developer point of view.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants