Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acquisition: calculate indexed fields #2512

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

BadrAly
Copy link

@BadrAly BadrAly commented Nov 9, 2021

  • Fixes a problem when calculating the expenditure.
  • Fixes a problem when calculating order quantity received.
  • Add units testing for complete acquisition workflow.

Co-Authored-by: Aly Badr aly.badr@rero.ch

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@BadrAly BadrAly added the f: acquisitions Related to the acquisition module label Nov 9, 2021
@BadrAly BadrAly self-assigned this Nov 9, 2021
@BadrAly BadrAly marked this pull request as ready for review November 10, 2021 07:47
* Fixes a problem when calculating the expenditure.
* Fixes a problem when calculating order quantity received.
* Add units testing for complete acquisition workflow.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@BadrAly BadrAly merged commit 040b3fb into rero:US_acquisition Nov 10, 2021
@BadrAly BadrAly deleted the baa-2341-better-calc branch November 10, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: acquisitions Related to the acquisition module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants