Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schema: correct errored values of https #2866

Merged
merged 1 commit into from
May 3, 2022
Merged

schema: correct errored values of https #2866

merged 1 commit into from
May 3, 2022

Conversation

BadrAly
Copy link

@BadrAly BadrAly commented Apr 29, 2022

  • Uses insinstance instead of get_schema_for_resource when possible.

Co-Authored-by: Aly Badr aly.badr@rero.ch the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@BadrAly BadrAly added bug Breaks something but is not blocking f: data migration Data migration from a legacy system or a previous version dev: fixtures Fixtures data used for ils.test and ilsdev.test labels Apr 29, 2022
@BadrAly BadrAly self-assigned this Apr 29, 2022
@github-actions github-actions bot added developers From a developer point of view. f: user management and removed dev: fixtures Fixtures data used for ils.test and ilsdev.test f: data migration Data migration from a legacy system or a previous version labels Apr 29, 2022
@BadrAly BadrAly marked this pull request as ready for review May 2, 2022 07:10
@BadrAly BadrAly requested review from rerowep, zannkukai and jma May 2, 2022 07:10
@BadrAly BadrAly added f: data migration Data migration from a legacy system or a previous version dev: fixtures Fixtures data used for ils.test and ilsdev.test and removed developers From a developer point of view. f: user management labels May 2, 2022
schema: correct errored values of https
224c843 
* Uses insinstance instead of get_schema_for_resource when possible.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@github-actions github-actions bot added developers From a developer point of view. f: user management and removed f: data migration Data migration from a legacy system or a previous version dev: fixtures Fixtures data used for ils.test and ilsdev.test labels May 2, 2022
@BadrAly BadrAly merged commit b20fe1b into rero:staging May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zannkukai zannkukai zannkukai approved these changes

@rerowep rerowep rerowep approved these changes

@jma jma Awaiting requested review from jma

Assignees

@BadrAly BadrAly

Labels
bug Breaks something but is not blocking developers From a developer point of view. f: user management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BadrAly @zannkukai @rerowep