Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebooks: fix dojson subjects #2888

Merged
merged 1 commit into from
May 10, 2022
Merged

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented May 9, 2022

  • Fixes dublicated subjects.

Co-Authored-by: Peter Weber peter.weber@rero.ch

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@rerowep rerowep self-assigned this May 9, 2022
@github-actions github-actions bot added the f: data About data model, importation, transformation, exportation of data, specific for bibliographic data label May 9, 2022
Copy link
Contributor

@zannkukai zannkukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should rebase because I also updates the dojson for subject in "subject subdivision" PR

@rerowep rerowep force-pushed the wep-fix-ebook-dojson branch 2 times, most recently from 4b631a3 to 08ad8a8 Compare May 9, 2022 12:55
* Fixes dublicated subjects.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
@rerowep rerowep merged commit 36eaf99 into rero:staging May 10, 2022
@rerowep rerowep deleted the wep-fix-ebook-dojson branch May 10, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: data About data model, importation, transformation, exportation of data, specific for bibliographic data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants