Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selfcheck: fix messages translations #3633

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

lauren-d
Copy link
Contributor

@lauren-d lauren-d commented Mar 25, 2024

selfcheck translations needs to work outside of the application context.

@lauren-d lauren-d self-assigned this Mar 25, 2024
@github-actions github-actions bot added the f: circulation Concerns the circulation interface or backend label Mar 25, 2024
@lauren-d lauren-d marked this pull request as draft March 25, 2024 07:41
@lauren-d lauren-d force-pushed the lau-fix-message-translations branch 3 times, most recently from 7133415 to 7adbba2 Compare March 25, 2024 15:44
@lauren-d lauren-d marked this pull request as ready for review April 4, 2024 08:00
rero_ils/modules/selfcheck/api.py Outdated Show resolved Hide resolved
rero_ils/modules/selfcheck/api.py Outdated Show resolved Hide resolved
rero_ils/modules/selfcheck/api.py Outdated Show resolved Hide resolved
rero_ils/modules/selfcheck/api.py Show resolved Hide resolved
rero_ils/modules/selfcheck/api.py Outdated Show resolved Hide resolved
selfcheck translations needs to work outside of the application context.

* Uses `force_locale` method from babel package.
* Closes: rero#3423.

Co-Authored-by: Laurent Dubois <laurent.dubois@itld-solutions.be>
@lauren-d lauren-d force-pushed the lau-fix-message-translations branch from 7adbba2 to 441f9c0 Compare April 8, 2024 08:05
@lauren-d lauren-d requested a review from rerowep April 8, 2024 08:16
@lauren-d lauren-d merged commit 0f13a24 into rero:staging Apr 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: circulation Concerns the circulation interface or backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIP2: fix messages translations
4 participants