Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems in the document editor within field partOf #626

Closed
pronguen opened this issue Aug 11, 2021 · 2 comments · Fixed by #887
Closed

Problems in the document editor within field partOf #626

pronguen opened this issue Aug 11, 2021 · 2 comments · Fixed by #887
Assignees
@PascalRepond
Labels
bug Breaks something but is not blocking f: editor Concerns editor based on JSON schema AND custom editor p-High To set a high priority!
Projects
SONAR | This board has been replaced...

Comments

@pronguen
Copy link
Contributor

pronguen commented Aug 11, 2021 •
edited
Loading

Describe the issue

In the document editor, with the partOf field

  1. Sometimes I cannot to add the following sub-fields: numberingVolume, numberingIssues depending of the document type.
  2. When editing an existing document, the sub-field document.contribution is not displayed even if it already contains data

This might be the case also for other sub-fields.

To Reproduce

  1. Open a new document
  2. Add field "Contained in (host document" (partOf)
  3. Try to add the mentioned subfields

Expected behavior

  1. Allow to add
    • numberingVolume (document) and volume (deposit) for the following doc types: coar:c_3248, coar:c_3e5a, coar:c_beb9, coar:c_6501, coar:c_998f, coar:c_dcae04bc, coar:c_816b, coar:c_5794, coar:c_6670, coar:c_c94f
    • numberingIssue (document) and issue (deposit) for the following doc types: coar:c_3e5a, coar:c_beb9, coar:c_6501, coar:c_998f, coar:c_dcae04bc, coar:c_816b, coar:c_5794, coar:c_6670, coar:c_c94f
    • Always allow to add numberingPages / pages and numberingYear / year
  2. Solve problem 2

Software version
sonardev.test.rero.ch AND sonar.test.rero.ch

Screenshots
image
@pronguen pronguen added bug Breaks something but is not blocking f: editor Concerns editor based on JSON schema AND custom editor labels Aug 11, 2021
@pronguen
Copy link
Contributor Author

Seems to be solved

@pronguen
Copy link
Contributor Author

It is still present in v1.6.0, so I reopen it.

@pronguen pronguen reopened this Mar 22, 2022
@pronguen pronguen added the p-High To set a high priority! label Mar 22, 2022
@pronguen pronguen changed the title In the document editor, I have no way to add the following sub-fields: numberingVolume, numberingIssues Problems in the document editor within field partOf Mar 22, 2022
PascalRepond added a commit to PascalRepond/sonar that referenced this issue Aug 22, 2022
@PascalRepond
jsonschema: fix partOf subfields display
9e58bd9 
* Closes rero#626.
* Makes the `status` deposit field required to prevent submitting
a deposit with no status from the API.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
@PascalRepond PascalRepond mentioned this issue Aug 22, 2022
Merged
PascalRepond added a commit to PascalRepond/sonar that referenced this issue Aug 22, 2022
@PascalRepond
jsonschema: fix partOf subfields display
a0a3e96 
* Closes rero#626.
* Makes the `status` deposit field required to prevent submitting
a deposit with no status from the API.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit that referenced this issue Aug 23, 2022
@PascalRepond
jsonschema: fix partOf subfields display
d221129 
* Closes #626.
* Makes the `status` deposit field required to prevent submitting
a deposit with no status from the API.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
@PascalRepond PascalRepond self-assigned this Aug 23, 2022
PascalRepond added a commit to PascalRepond/sonar that referenced this issue Aug 25, 2022
@PascalRepond
jsonschema: fix partOf subfields display
38f0988 
* Closes rero#626.
* Makes the `status` deposit field required to prevent submitting
a deposit with no status from the API.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/sonar that referenced this issue Aug 25, 2022
@PascalRepond
jsonschema: fix partOf subfields display
4333435 
* Closes rero#626.
* Makes the `status` deposit field required to prevent submitting
a deposit with no status from the API.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit that referenced this issue Aug 25, 2022
@PascalRepond
jsonschema: fix partOf subfields display
09050b7 
* Closes #626.
* Makes the `status` deposit field required to prevent submitting
a deposit with no status from the API.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PascalRepond PascalRepond

Labels
bug Breaks something but is not blocking f: editor Concerns editor based on JSON schema AND custom editor p-High To set a high priority!
Projects
No open projects
SONAR | This board has been replaced...
Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

jsonschemas: add 2 new document types PascalRepond/sonar
2 participants
@pronguen @PascalRepond