Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For preprints, field partOf should be labelled into "Submitted to" [2] #722

Closed
mmo opened this issue Dec 1, 2021 · 1 comment · Fixed by #790
Closed

For preprints, field partOf should be labelled into "Submitted to" [2] #722

mmo opened this issue Dec 1, 2021 · 1 comment · Fixed by #790
Assignees
@Garfield-fr
Labels
enhancement Enhancement of an existing feature f: deposits Related to deposits f: professional ui f: public ui
Projects
SONAR | This board has been replaced...
Milestone
v1.6.0

Comments

@mmo
Copy link
Collaborator

mmo commented Dec 1, 2021 •
edited
Loading

Problem

For preprints, the field partOf.document.title is useful, meaning "Submitted to", but it is currently unavailable.

Improvement

  • In the document editor and the deposit editor:
    • the field partOf should be displayed for preprints (c_816b) (as for a journal article)
    • it should be renamed to "Contained in or submitted to (journal, book, proceedings)".
  • In the document detailed view (public and professional interface), the label "Published in" should be replaced by "Submitted to" in the case of preprints.
  • In the document schema, the subfield partOf.numberingYear should be optional for the document type "preprint" (c_816b).
@mmo mmo changed the title allow field partOf.document for preprints allow field partOf.document.title for preprints Dec 1, 2021
@pronguen pronguen added enhancement Enhancement of an existing feature f: deposits Related to deposits f: professional ui f: public ui labels Dec 15, 2021
@pronguen pronguen changed the title allow field partOf.document.title for preprints For preprints, field partOf should be labelled into "Submitted to" Dec 16, 2021
@mmo mmo changed the title For preprints, field partOf should be labelled into "Submitted to" For preprints, field partOf should be labelled into "Submitted to" [2] Jan 27, 2022
@Garfield-fr Garfield-fr self-assigned this Feb 10, 2022
Garfield-fr added a commit to Garfield-fr/sonar that referenced this issue Feb 24, 2022
@Garfield-fr
documents: label change for preprint
a6da941 
* Renames the title of the partof field with "Contained in or submitted to
  (journal, book, proceedings)".
* Changes the title field on detailed view with "Submitted to" for preprint.
* Closes rero#722.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr mentioned this issue Feb 24, 2022
Merged
7 tasks
@PascalRepond PascalRepond added this to the v1.6.0 milestone Feb 28, 2022
Garfield-fr added a commit that referenced this issue Mar 1, 2022
@Garfield-fr
documents: label change for preprint
d0c0bf1 
* Renames the title of the partof field with "Contained in or submitted to
  (journal, book, proceedings)".
* Changes the title field on detailed view with "Submitted to" for preprint.
* Closes #722.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@PascalRepond PascalRepond removed this from the v1.6.0 milestone Mar 1, 2022
@PascalRepond
Copy link
Contributor

date is optional for preprints but required for documents with a partOf. This creates a validation conflict and prevents saving preprints that have a partOf but no date.
The corresponding JSON schema conditions need to be clarified before this issue is cosidered done.

Garfield-fr added a commit to Garfield-fr/sonar that referenced this issue Mar 2, 2022
@Garfield-fr
documents: label change for preprint
222decf 
* Renames the title of the partof field with "Contained in or submitted to
  (journal, book, proceedings)".
* Changes the title field on detailed view with "Submitted to" for preprint.
* Closes rero#722.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit that referenced this issue Mar 2, 2022
@Garfield-fr
documents: label change for preprint
0ab2f66 
* Renames the title of the partof field with "Contained in or submitted to
  (journal, book, proceedings)".
* Changes the title field on detailed view with "Submitted to" for preprint.
* Closes #722.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@PascalRepond PascalRepond added this to the v1.6.0 milestone Mar 3, 2022
SONAR | This board has been replaced (see new link in the description). automation moved this from To be integrated to Done Mar 3, 2022
Garfield-fr added a commit that referenced this issue Mar 3, 2022
@Garfield-fr
documents: label change for preprint
23644a1 
* Renames the title of the partof field with "Contained in or submitted to
  (journal, book, proceedings)".
* Changes the title field on detailed view with "Submitted to" for preprint.
* Closes #722.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
enhancement Enhancement of an existing feature f: deposits Related to deposits f: professional ui f: public ui
Projects
No open projects
SONAR | This board has been replaced...
Done
Milestone
v1.6.0
Development

Successfully merging a pull request may close this issue.

documents: label change for preprint Garfield-fr/sonar
4 participants
@Garfield-fr @mmo @pronguen @PascalRepond