Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import swisscovery: the author's birth and death dates are not imported #791

Closed
pronguen opened this issue Feb 24, 2022 · 0 comments · Fixed by #792
Closed

Import swisscovery: the author's birth and death dates are not imported #791

pronguen opened this issue Feb 24, 2022 · 0 comments · Fixed by #792
Assignees
@Garfield-fr
Labels
correction An implemented feature doesn't work as expected f: data About data model, importation, transformation, exportation of data, specific for bibliographic data
Projects
SONAR | This board has been replaced...
Milestone
v1.7.0

Comments

@pronguen
Copy link
Contributor

pronguen commented Feb 24, 2022 •
edited
Loading

Problem

Import swisscovery: the author's birth and death dates are not imported.

Test is by importing this ISBN: 2070406237

This is because the deposit data model currently does not have these fields.

Expected behaviour

  • This fields are added to the deposit data model
    • TO BE DECIDED: should they be displayed for the submitter? This makes the form more complex...
  • They are imported according to spec file.
@pronguen pronguen added correction An implemented feature doesn't work as expected f: data About data model, importation, transformation, exportation of data, specific for bibliographic data labels Feb 24, 2022
Garfield-fr added a commit to Garfield-fr/sonar that referenced this issue Feb 24, 2022
@Garfield-fr
swisscovery: import of the contributor's date of birth and death
aec795c 
* Adds 2 fields date_of_birth and date_of_death in deposit json schema.
* Updates of the import of these 2 new fields.
* Closes rero#791.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr mentioned this issue Feb 24, 2022
Merged
7 tasks
@Garfield-fr Garfield-fr self-assigned this Feb 24, 2022
Garfield-fr added a commit to Garfield-fr/sonar that referenced this issue Feb 24, 2022
@Garfield-fr
swisscovery: import of the contributor's date of birth and death
ff8b768 
* Adds 2 fields date_of_birth and date_of_death in deposit json schema.
* Updates of the import of these 2 new fields.
* Closes rero#791.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/sonar that referenced this issue Feb 24, 2022
@Garfield-fr
swisscovery: import of the contributor's date of birth and death
f40f24a 
* Adds 2 fields date_of_birth and date_of_death in deposit json schema.
* Updates of the import of these 2 new fields.
* Closes rero#791.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/sonar that referenced this issue Mar 15, 2022
@Garfield-fr
swisscovery: import of the contributor's date of birth and death
b1e2991 
* Adds 2 fields date_of_birth and date_of_death in deposit json schema.
* Updates of the import of these 2 new fields.
* Closes rero#791.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit that referenced this issue Mar 15, 2022
@Garfield-fr
swisscovery: import of the contributor's date of birth and death
fe0d22a 
* Adds 2 fields date_of_birth and date_of_death in deposit json schema.
* Updates of the import of these 2 new fields.
* Closes #791.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/sonar that referenced this issue Mar 15, 2022
@Garfield-fr
swisscovery: import of the contributor's date of birth and death
28415ba 
* Adds 2 fields date_of_birth and date_of_death in deposit json schema.
* Updates of the import of these 2 new fields.
* Closes rero#791.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit that referenced this issue Mar 15, 2022
@Garfield-fr
swisscovery: import of the contributor's date of birth and death
62b45ef 
* Adds 2 fields date_of_birth and date_of_death in deposit json schema.
* Updates of the import of these 2 new fields.
* Closes #791.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/sonar that referenced this issue Mar 15, 2022
@Garfield-fr
swisscovery: import of the contributor's date of birth and death
994bd07 
* Adds 2 fields date_of_birth and date_of_death in deposit json schema.
* Updates of the import of these 2 new fields.
* Closes rero#791.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit that referenced this issue Mar 15, 2022
@Garfield-fr
swisscovery: import of the contributor's date of birth and death
f4ae0e7 
* Adds 2 fields date_of_birth and date_of_death in deposit json schema.
* Updates of the import of these 2 new fields.
* Closes #791.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@PascalRepond PascalRepond added this to the v1.7.0 milestone Mar 16, 2022
Garfield-fr added a commit that referenced this issue Mar 17, 2022
@Garfield-fr
swisscovery: import of the contributor's date of birth and death
e3e6a58 
* Adds 2 fields date_of_birth and date_of_death in deposit json schema.
* Updates of the import of these 2 new fields.
* Closes #791.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
correction An implemented feature doesn't work as expected f: data About data model, importation, transformation, exportation of data, specific for bibliographic data
Projects
No open projects
SONAR | This board has been replaced...
Done
Milestone
v1.7.0
Development

Successfully merging a pull request may close this issue.

swisscovery: import of the contributor's date of birth and death Garfield-fr/sonar
3 participants
@Garfield-fr @pronguen @PascalRepond