Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controlled affiliation should be cleared when affiliation is modified to empty or unrecognized value #807

Closed
PascalRepond opened this issue Mar 15, 2022 · 1 comment · Fixed by #913
Closed

Controlled affiliation should be cleared when affiliation is modified to empty or unrecognized value #807

PascalRepond opened this issue Mar 15, 2022 · 1 comment · Fixed by #913
Labels
client request correction An implemented feature doesn't work as expected f: professional ui p-Low To set a low priority.

Comments

@PascalRepond
Copy link
Contributor

PascalRepond commented Mar 15, 2022 •
edited
Loading

How it works

If I change the affiliation of a contributor to one that is not recognized by the controlled affiliation mechanism, the controlled affiliation field keeps the last recognized value instead of being cleared.

test3

To reproduce

  1. Add a recognized affiliation to any document (example Uni Lausanne) and save: the controlled affiliation recognizes Uni of Lausanne and CHUV
  2. Edit the document again and change the affiliation to something that won't be recognized (example: Charrat) and save: the controlled affiliation field still displays Uni of Lausanne and CHUV

Improvement suggestion

The controlled affiliation field should be emptied if affiliation is modified to an empty or unrecognized value.
@PascalRepond PascalRepond added correction An implemented feature doesn't work as expected p-Low To set a low priority. f: professional ui labels Mar 15, 2022
@PascalRepond PascalRepond mentioned this issue Mar 15, 2022
Merged
7 tasks
@github-actions
Copy link

This issue is stale because it has been open 6 months with no activity.

@github-actions github-actions bot added the stale Stale or no longer relevant label Sep 12, 2022
@PascalRepond PascalRepond removed the stale Stale or no longer relevant label Sep 12, 2022
@PascalRepond PascalRepond reopened this Sep 12, 2022
@PascalRepond PascalRepond changed the title Controlled affiliation should be cleared when affiliation is modified to unrecognized value Controlled affiliation should be cleared when affiliation is modified to empty or unrecognized value Nov 18, 2022
jma added a commit to jma/sonar that referenced this issue Nov 23, 2022
@jma @PascalRepond
documents: clear controlled affiliations
2f33a44 
* Closes rero#807.
* Removes controlled affiliations because sometimes a controlled
  affiliation becomes uncontrolled.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Co-Authored-by:  Pascal Repond <pascal.repond@rero.ch>
@jma jma mentioned this issue Nov 23, 2022
Merged
7 tasks
jma added a commit to jma/sonar that referenced this issue Nov 23, 2022
@jma @PascalRepond
documents: clear controlled affiliations
e175d7d 
* Closes rero#807.
* Removes controlled affiliations because sometimes a controlled
  affiliation becomes uncontrolled.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Co-Authored-by:  Pascal Repond <pascal.repond@rero.ch>
@jma jma closed this as completed in #913 Nov 24, 2022
jma added a commit that referenced this issue Nov 24, 2022
@jma @PascalRepond
documents: clear controlled affiliations
4ed6af9 
* Closes #807.
* Removes controlled affiliations because sometimes a controlled
  affiliation becomes uncontrolled.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Co-Authored-by:  Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit that referenced this issue Dec 1, 2022
@jma @PascalRepond
documents: clear controlled affiliations
b1e2f5b 
* Closes #807.
* Removes controlled affiliations because sometimes a controlled
  affiliation becomes uncontrolled.
* In case where there is no affiliation, the controlledAffiliation field
should also be cleared.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Co-Authored-by:  Pascal Repond <pascal.repond@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client request correction An implemented feature doesn't work as expected f: professional ui p-Low To set a low priority.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

documents: clear controlled affiliations jma/sonar
1 participant
@PascalRepond