Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help: files are not displayed in case of a view code #817

Closed
pronguen opened this issue Mar 30, 2022 · 0 comments · Fixed by #830
Closed

Help: files are not displayed in case of a view code #817

pronguen opened this issue Mar 30, 2022 · 0 comments · Fixed by #830
Assignees
@Garfield-fr
Labels
bug Breaks something but is not blocking

Comments

@pronguen
Copy link
Contributor

pronguen commented Mar 30, 2022 •
edited
Loading

Problem

When the help is displayed with a view code (ex: https://sonar.test.rero.ch/rero/help/collections/)

  • files (i.e. images) are not displayed
  • files menu is not displayed

If there is no view code, it works (ex: https://sonar.test.rero.ch/help/collections/)

Expected behaviour

Even if there is a view code:

  1. Images/files are displayed for the end user
  2. Files menu is available
@pronguen pronguen added the bug Breaks something but is not blocking label Mar 30, 2022
@Garfield-fr Garfield-fr self-assigned this Apr 20, 2022
Garfield-fr added a commit to Garfield-fr/sonar that referenced this issue Apr 20, 2022
@Garfield-fr
help: fix images are not displayed
0d94056 
* Fixes the image display on the case of a view code.
* Closes rero#817.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr mentioned this issue Apr 20, 2022
Merged
7 tasks
Garfield-fr added a commit to Garfield-fr/sonar that referenced this issue Apr 20, 2022
@Garfield-fr
help: fix images are not displayed
35a5b0b 
* Fixes the image display on the case of a view code.
* Closes rero#817.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit that referenced this issue Apr 20, 2022
@Garfield-fr
help: fix images are not displayed
16e07f1 
* Fixes the image display on the case of a view code.
* Closes #817.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit that referenced this issue Apr 21, 2022
@Garfield-fr
help: fix images are not displayed
578538d 
* Fixes the image display on the case of a view code.
* Closes #817.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit that referenced this issue Apr 27, 2022
@Garfield-fr
help: fix images are not displayed
73c893f 
* Fixes the image display on the case of a view code.
* Closes #817.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
bug Breaks something but is not blocking
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

help: fix images are not displayed Garfield-fr/sonar
2 participants
@Garfield-fr @pronguen