Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: adapt to new ng-core version #860

Closed
3 of 4 tasks
PascalRepond opened this issue Jun 14, 2022 · 0 comments · Fixed by rero/sonar-ui#320
Closed
3 of 4 tasks

Editor: adapt to new ng-core version #860

PascalRepond opened this issue Jun 14, 2022 · 0 comments · Fixed by rero/sonar-ui#320
Assignees
Labels
dev: dependencies Related to a dependency that needs to be fixed, or pinned, or changed enhancement Enhancement of an existing feature f: editor Concerns editor based on JSON schema AND custom editor

Comments

@PascalRepond
Copy link
Contributor

PascalRepond commented Jun 14, 2022

How it works

The editors in SONAR need to be adapted to work with the new version of ng-core developed for RERO ILS. Some functionnalities aren't what is expected anymore. Adapt Jsonschemas and UI to get expected functionnality.

List of corrections

Do not mention any already existing bugs, only problems created by latest ng-core version. Compare sonardev with sonar.test

Document editor

  • abstract.value should be a textarea
  • Duplicating subject field from existing field hides subject.source and subject.label.language in new field but duplicating from empty or newly added field doesn't.
    • REP/24.08: Not fixed but not blocking.
  • Impossible to edit and save a DEDICATED organisation, even if no change is made in the data. There seems to be a validation error with the serverName field.
{"status": 400, "message": "Validation error.", "errors": [{"parents": [], "field": "serverName", "message": "Unknown field."}]}
  • Editing organisations: the menu to add fields should not be active. All fields are displayed in this editor, unless explicitly stated in the jsonschema.
    • as is, it suggests fields of dedicated organisation for the editor of a shared organisation.
    • and suggests fields already present in the editor (in case of dedicated org only)
      image
@PascalRepond PascalRepond added enhancement Enhancement of an existing feature dev: dependencies Related to a dependency that needs to be fixed, or pinned, or changed f: editor Concerns editor based on JSON schema AND custom editor labels Jun 14, 2022
PascalRepond added a commit to PascalRepond/sonar-ui that referenced this issue Aug 23, 2022
* Disables long mode for organisation editor to prevent unwanted fields.
* Updates dependency ngx-formly to ^5.12.4.
* Closes rero/sonar#860.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
@PascalRepond PascalRepond self-assigned this Aug 23, 2022
PascalRepond added a commit to rero/sonar-ui that referenced this issue Aug 25, 2022
* Disables long mode for organisation editor to prevent unwanted fields.
* Updates dependency ngx-formly to ^5.12.4.
* Closes rero/sonar#860.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev: dependencies Related to a dependency that needs to be fixed, or pinned, or changed enhancement Enhancement of an existing feature f: editor Concerns editor based on JSON schema AND custom editor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant