Link to file is broken when the file name contains special characters

[pronguen]

Problem

Editing a document/file can break the link to a file if it contains certain characters.

How to reproduce

• Add a file to a document with a filename with special characters: Ex:"TB_Gozübüyük_Jerad_2023.pdf"
• See that the upload seems to work fine, the file can be seen in the public view
• Edit and save the document or the file
• See that the file with the special character cannot be opened anymore

Expected behaviour

Even if a file has special characters, editing or reindexing should not break the ability to access this file.

[pronguen]

Discussion during grooming:

• Various options to solve the problem:
  1. Generate automatically a new numeric file name and store the submitted name in the header (need to override standard Invenio behaviour)
  2. Keep the submitted file name, but without all non-ASCII characters
  3. Check the validity of the file name, and ask the end user to change it if it is not valid

[jma]

It seems that has been fixed by other packages. To fix existing:

doc = DocumentRecord.get_record_by_pid('xxx')
doc.sync_files(list(doc.files)[0])

[PascalRepond]

Reopening this issue with a better description of a way to consistently reproduce.