files: fix upload of files with special characters in filename #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
vgranata
force-pushed
the
grv-861-fix-file-broken-link
branch
from
841d166
to
c1c208b
Compare
7 tasks
jma
requested changes
Sep 28, 2022
| @@ -40,7 +40,7 @@ | |||
| </ng-container> | |||
| <ng-template #downloadLink> | |||
| <ng-container *ngIf="showDownload && file.links.download; else noLink"> | |||
| <a href="{{ file.links.download }}?download" *ngIf="showDownload && file.links.download"> | |||
There was a problem hiding this comment.
Why did you remove ngIf the property showDownload still used in the component?
There was a problem hiding this comment.
Because it is already in the line above:
<ng-container *ngIf="showDownload && file.links.download; else noLink">
| Object.keys(file.links).forEach((key) => { | ||
| if (['download', 'preview'].includes(key)) { | ||
| if (file.links[key]) { | ||
| file.links[key] = file.links[key].replace(file.key, file.key.normalize('NFD')); |
There was a problem hiding this comment.
I would use a pipe instead. Original data should stay untouched.
vgranata
force-pushed
the
grv-861-fix-file-broken-link
branch
from
c1c208b
to
de9ef31
Compare
Co-Authored-by: Valeria Granata <valeria@chaw.com>
vgranata
force-pushed
the
grv-861-fix-file-broken-link
branch
from
de9ef31
to
719c8eb
Compare
|
This PR is stale because it has been open 6 months with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unicode normalize filenames
files: fix upload of files with special characters in filename sonar#901
files: fix upload of files with special characters in filename ng-core#523
Co-Authored-by: Valeria Granata valeria@chaw.com
Why are you opening this PR?
rero/sonar#861
Code review check list