Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 2 document types: conference object, book review #881

Closed
pronguen opened this issue Aug 9, 2022 · 0 comments · Fixed by #887
Closed

Add 2 document types: conference object, book review #881

pronguen opened this issue Aug 9, 2022 · 0 comments · Fixed by #887
Assignees
@PascalRepond
Labels
effort: minor Solved quickly enhancement Enhancement of an existing feature f: data About data model, importation, transformation, exportation of data, specific for bibliographic data p-High To set a high priority!

Comments

@pronguen
Copy link
Contributor

pronguen commented Aug 9, 2022 •
edited
Loading

How it works

  1. On request of the SONAR users, two document types are needed:
  • coar:R60J-J5BD - Conference presentation
  • coar:c_ba08 - Book review
  1. Other thesis is not clear in the JSON schema.

Improvement suggestion

  1. Add this 2 document types
  • in the JSON schema of the deposit and of the document
    • coar:R60J-J5BD (Conference presentation): settings similar to coar:c_18co (conference poster not in proceedings)
    • coar:c_ba08 (Book review): settings similar to coar:c_3e5a (contribution to a journal)
  • in the schema.org mapping:
    • coar:R60J-J5BD = CreativeWork
    • coar:c_ba08 = Review
  1. Rename "Other" (under "Thesis") to "Other type of thesis"
    • replace document_type_other by document_type_other_thesis
    • check if other is used in hide conditions
@pronguen pronguen added enhancement Enhancement of an existing feature f: data About data model, importation, transformation, exportation of data, specific for bibliographic data p-High To set a high priority! effort: minor Solved quickly labels Aug 9, 2022
@PascalRepond PascalRepond self-assigned this Aug 17, 2022
PascalRepond added a commit to PascalRepond/sonar that referenced this issue Aug 17, 2022
@PascalRepond
jsonschemas: add conference object, book review document types
9395aa2 
* Adds 2 new document types for documents and deposits.
* Closes rero#881

⚠️ ES update mapping

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
@PascalRepond PascalRepond mentioned this issue Aug 17, 2022
Closed
PascalRepond added a commit to PascalRepond/sonar that referenced this issue Aug 17, 2022
@PascalRepond
jsonschemas: add conference object, book review document types
ef4ea69 
* Adds 2 new document types for documents and deposits.
* Change code for document_type_other for better clarity.
* Closes rero#881.

⚠️ ES update mapping

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/sonar that referenced this issue Aug 18, 2022
@PascalRepond
jsonschemas: add 2 new document types
7617f78 
* Adds conference object and book review document types for documents
and deposits.
* Change code for document_type_other for better clarity.
* Initialize alembic.
* Includes alembic script for db migration.
* Closes rero#881.

⚠️ ES update mapping

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/sonar that referenced this issue Aug 18, 2022
@PascalRepond
jsonschemas: add 2 new document types
27bcda3 
* Adds conference object and book review document types for documents
and deposits.
* Changes value and label for document_type_other for better clarity.
* Initializes alembic.
* Includes alembic script for db migration.
* Closes rero#881.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
@PascalRepond PascalRepond mentioned this issue Aug 18, 2022
Merged
PascalRepond added a commit to PascalRepond/sonar that referenced this issue Aug 19, 2022
@PascalRepond
jsonschemas: add 2 new document types
11236f2 
* Adds conference object and book review document types for documents
and deposits.
* Changes value and label for document_type_other for better clarity.
* Initializes alembic.
* Includes alembic script for db migration.
* Closes rero#881.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit that referenced this issue Aug 23, 2022
@PascalRepond
jsonschemas: add 2 new document types
e70c633 
* Adds conference object and book review document types for documents
and deposits.
* Changes value and label for document_type_other for better clarity.
* Initializes alembic.
* Includes alembic script for db migration.
* Closes #881.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/sonar that referenced this issue Aug 25, 2022
@PascalRepond
jsonschemas: add 2 new document types
6b9de3d 
* Adds conference object and book review document types for documents
and deposits.
* Changes value and label for document_type_other for better clarity.
* Initializes alembic.
* Includes alembic script for db migration.
* Closes rero#881.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit that referenced this issue Aug 25, 2022
@PascalRepond
jsonschemas: add 2 new document types
190c4f6 
* Adds conference object and book review document types for documents
and deposits.
* Changes value and label for document_type_other for better clarity.
* Initializes alembic.
* Includes alembic script for db migration.
* Closes #881.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PascalRepond PascalRepond

Labels
effort: minor Solved quickly enhancement Enhancement of an existing feature f: data About data model, importation, transformation, exportation of data, specific for bibliographic data p-High To set a high priority!
Projects
None yet
Milestone
No milestone
2 participants
@pronguen @PascalRepond