authentication: ORCID OAuth #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can use this ORCID test account: Username: sebastien.deleze@rero.ch |
jma
requested changes
Jul 9, 2019
sonar/config.py
Outdated
| 'sonar.ch', | ||
| 'localhost', | ||
| '127.0.0.1', | ||
| 'sonardev.test.rero.ch', |
There was a problem hiding this comment.
It's not mandatory, I removed it..
sonar/modules/oauth/ext.py
Outdated
| @@ -0,0 +1,31 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
why do you need an new extension?
There was a problem hiding this comment.
I effectively don't need an extension. That's now removed
sonar/modules/oauth/orcid.py
Outdated
| 'full_name': 'Full Name', | ||
| }, | ||
| }, | ||
| 'external_id': 'github-unique-identifier', |
sonar/modules/oauth/orcid.py
Outdated
|
|
||
| :param orcid_id: ORCID identifier | ||
| :param token: Access token for querying API | ||
| :return: Dict of record or None |
There was a problem hiding this comment.
would be nice to have an idea of the form of the returned record.
There was a problem hiding this comment.
I provided an example in the docstring, but not with the full structure, because it's quite long
jma
approved these changes
Jul 22, 2019
NEW OAuth authentication with ORCID api. Signed-off-by: Sébastien Délèze <sebastien.deleze@rero.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEW OAuth authentication with ORCID api.