Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documents: add a configuration for links on identifiers #782

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Feb 16, 2022

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

How to test?

  • Check identifiers on identifiedBy for the document detailed view.
  • Check identifiers on agent for the document detailed view.
  • Check identifiers for the project detailed view.

Dependencies

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@Garfield-fr Garfield-fr force-pushed the zub-identifier-link branch 4 times, most recently from dbc48d4 to f8f6f3f Compare February 16, 2022 14:15
@Garfield-fr Garfield-fr self-assigned this Feb 16, 2022
@pronguen
Copy link
Contributor

pronguen commented Mar 1, 2022

  • NPR: these documents loads forever in the professional interface:
  • PRE: When adding a new local identifier to a document, I am able to save it even if I don't enter a source (if I edit it again, I can't save it without a source)
  • [not blocking:] NPR: For contribution, we should only show the orcid identifier (type="bf:Local" AND source=orcid). The others are not authors identifiers and they charge the interface.
    image
  • [not blocking:] NPR: Identifiers of type "uri" should be clickable too.
  • [not blocking:] NPR: there are small case differences between the pro and the public views:
    image

* Closes rero#711.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr merged commit b1d2540 into rero:staging Mar 7, 2022
@Garfield-fr Garfield-fr deleted the zub-identifier-link branch March 8, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make swisscovery identifiers clickable
4 participants