Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documents: fix abstracts sort #812

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Mar 21, 2022

The languages of the abstracts that are not in the preferred
sorting languages are added at the end of the list and sorted
alphabetically by language code.

  • Fixes Sentry SONAR-EA.

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@Garfield-fr Garfield-fr self-assigned this Mar 21, 2022
@Garfield-fr Garfield-fr force-pushed the zub-abstacts-fix branch 2 times, most recently from a8924da to 23055a9 Compare March 21, 2022 09:56
@Garfield-fr Garfield-fr changed the title documents: fix abstract sort documents: fix abstracts sort Mar 21, 2022
@Garfield-fr Garfield-fr added the bug Breaks something but is not blocking label Mar 21, 2022
@Garfield-fr Garfield-fr requested review from jma, mmo and rerowep March 21, 2022 10:30
Copy link
Contributor

@pronguen pronguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works perfectly 💯

The languages of the abstracts that are not in the preferred
sorting languages are added at the end of the list and sorted
alphabetically by language code.

* Fixes Sentry SONAR-EA.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr merged commit 805bbe3 into rero:staging Mar 28, 2022
@Garfield-fr Garfield-fr deleted the zub-abstacts-fix branch March 28, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks something but is not blocking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants