Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update flask-wiki to 0.2.1 #869

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Conversation

PascalRepond
Copy link
Contributor

  • Updates flask-wiki to latest version
  • Removes container in wiki template to use full width of the page

Co-Authored-by: Pascal Repond pascal.repond@rero.ch

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

Copy link
Contributor

@Garfield-fr Garfield-fr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a good structure to read. Please add le content in a new page and include this.

@@ -142,7 +142,7 @@
{%- endblock header %}
</header>

<div class="container my-5">
{% block container %}<div class="container my-5">{% endblock container %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This div is never closed. I do not understand what you are trying to do.

Flask-WTF = "*"
Markdown = "*"
WTForms = "*"
babel = ">=2.9.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All dependencies has been updated. You probably edit the pyproject file by hand instead of using the poetry command.

@jma jma removed their request for review August 10, 2022 06:28
@PascalRepond PascalRepond force-pushed the rep-wiki branch 4 times, most recently from 2d4f3af to d3f3315 Compare August 10, 2022 09:44
* Updates flask-wiki to latest version.
* Changes container in wiki template to use full width of the page.
* Updates dependencies criteria to account for poetry bug that Updates
all extras when adding a package.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants