Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: OAI-PMH crash for document containing control chars #908

Merged
merged 2 commits into from
Nov 22, 2022
Merged

fix: OAI-PMH crash for document containing control chars #908

merged 2 commits into from
Nov 22, 2022

Conversation

jma
Copy link
Contributor

@jma jma commented Nov 8, 2022 •
edited
Loading

  • Adds new safety exceptions.
  • Removes controls chars when the dublin core xml file is produced.
  • Closes The editor or API should prevent bad character encodings #867.
  • Updated docker base image.
  • Adds a second test scenario with latest dependencies versions.
  • Fixes dependencies with last versions.
  • Copies static files for productions.
  • Adds --ci option for the bootstrap script.

Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@jma jma marked this pull request as ready for review November 9, 2022 06:54
@jma jma requested review from rerowep and mmo November 9, 2022 06:54
@PascalRepond
Copy link
Contributor

Closes #867 ?

@jma jma force-pushed the maj-fix-xml-control-char branch 3 times, most recently from 0e98ba9 to 59ccc1f Compare November 16, 2022 13:46
@jma
fix: OAI-PMH crash for document containing control chars
4889282 
* Adds new `safety` exceptions.
* Removes controls chars when the dublin core xml file is produced.
* Closes rero#867.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma
deployment: fix docker image creation
b16da4e 
* Updated docker base image.
* Adds a second test scenario with latest dependencies versions.
* Fixes dependencies with last versions.
* Copies static files for productions.
* Adds --ci option for the bootstrap script.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma requested review from rerowep and mmo November 16, 2022 14:51
@jma jma merged commit 78edd42 into rero:staging Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmo mmo mmo approved these changes

@rerowep rerowep rerowep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The editor or API should prevent bad character encodings
4 participants
@jma @PascalRepond @mmo @rerowep