Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

files: fix record retrieval from the file bucket #950

Merged
merged 1 commit into from
Sep 27, 2023
Merged

files: fix record retrieval from the file bucket #950

merged 1 commit into from
Sep 27, 2023

Conversation

jma
Copy link
Contributor

@jma jma commented Sep 27, 2023

  • Adds cryptograpy exceptions.
  • Replaces the hard coded filter by the list of known REST endpoints when a record is
    retrieved for a given bucket.

Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@jma
files: fix record retrieval from the file bucket
46ae7db 
- Adds cryptograpy exceptions.
- Replaces the hard coded filter by the list of known REST endpoints when a record is
  retrieved for a given bucket.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma marked this pull request as ready for review September 27, 2023 08:00
@jma jma merged commit d7eef23 into rero:staging Sep 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@PascalRepond PascalRepond PascalRepond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jma @Garfield-fr @PascalRepond