Skip to content

Commit

Permalink
Fix incorrect assertion on ecma_op_function_has_instance (jerryscript…
Browse files Browse the repository at this point in the history
…-project#3827)

This patch fixes jerryscript-project#3814.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
  • Loading branch information
Robert Fancsik committed Jun 2, 2020
1 parent 9ceece8 commit dc837d2
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 1 deletion.
3 changes: 2 additions & 1 deletion jerry-core/ecma/operations/ecma-function-object.c
Expand Up @@ -641,7 +641,8 @@ ecma_op_function_has_instance (ecma_object_t *func_obj_p, /**< Function object *
}

JERRY_ASSERT (ecma_get_object_type (func_obj_p) == ECMA_OBJECT_TYPE_FUNCTION
|| ecma_get_object_type (func_obj_p) == ECMA_OBJECT_TYPE_EXTERNAL_FUNCTION);
|| ecma_get_object_type (func_obj_p) == ECMA_OBJECT_TYPE_EXTERNAL_FUNCTION
|| ECMA_OBJECT_IS_PROXY (func_obj_p));

ecma_object_t *v_obj_p = ecma_get_object_from_value (value);

Expand Down
17 changes: 17 additions & 0 deletions tests/jerry/es2015/regression-test-issue-3814.js
@@ -0,0 +1,17 @@
// Copyright JS Foundation and other contributors, http://js.foundation
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

function f () {}

assert((new f) instanceof new Proxy(f, {}))

0 comments on commit dc837d2

Please sign in to comment.