Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior::on_tab_button can now add context menus, on hover ui etc. #23

Merged
merged 1 commit into from Nov 10, 2023

Conversation

mkrueger
Copy link
Contributor

@mkrueger mkrueger commented Sep 2, 2023

Allows the user to set a context menu on each tab.

Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

Sorry for the slow review 😬 - thank you for your patiance!

@emilk emilk added the enhancement New feature or request label Nov 10, 2023
@emilk emilk changed the title Behavior on_tab_button method can now add context menus, on hover ui …etc. Behavior::on_tab_button can now add context menus, on hover ui etc. Nov 10, 2023
@emilk emilk merged commit 1e63bd2 into rerun-io:main Nov 10, 2023
5 of 6 checks passed
@mkrueger
Copy link
Contributor Author

@emilk No problem about slow reviews - I do open source development as well :)

You're doing a good job with your libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants