public iter_external_loaders

rerun-io · Dec 14, 2023 · 4995c64 · 4995c64
1 parent 1853070
commit 4995c64
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 4 deletions.
diff --git a/crates/re_data_source/src/data_loader/loader_external.rs b/crates/re_data_source/src/data_loader/loader_external.rs
@@ -44,6 +44,14 @@ pub static EXTERNAL_LOADER_PATHS: Lazy<Vec<std::path::PathBuf>> = Lazy::new(|| {
     executables.into_iter().collect()
 });
 
+/// Iterator over all registered [`DataLoader`]s.
+#[inline]
+pub fn iter_external_loaders() -> impl ExactSizeIterator<Item = std::path::PathBuf> {
+    EXTERNAL_LOADER_PATHS.iter().cloned()
+}
+
+// ---
+
 // TODO: this is the stdio integration
 // TODO: binary plugin example and indicate how to not care about ext
 pub struct ExternalDataLoader;
@@ -54,7 +62,7 @@ impl crate::DataLoader for ExternalDataLoader {
         "rerun.data_loaders.External".into()
     }
 
-    fn load_from_file(
+    fn load_from_path(
         &self,
         store_id: re_log_types::StoreId,
         filepath: std::path::PathBuf,
@@ -127,7 +135,7 @@ impl crate::DataLoader for ExternalDataLoader {
     }
 
     #[inline]
-    fn load_from_file_contents(
+    fn load_from_path_contents(
         &self,
         _store_id: re_log_types::StoreId,
         _path: std::path::PathBuf,

diff --git a/crates/re_data_source/src/data_loader/mod.rs b/crates/re_data_source/src/data_loader/mod.rs
@@ -189,4 +189,6 @@ pub use self::loader_rrd::RrdLoader;
 #[cfg(not(target_arch = "wasm32"))]
 pub(crate) use self::loader_external::EXTERNAL_LOADER_PATHS;
 #[cfg(not(target_arch = "wasm32"))]
-pub use self::loader_external::{ExternalDataLoader, EXTERNAL_DATA_LOADER_PREFIX};
+pub use self::loader_external::{
+    iter_external_loaders, ExternalDataLoader, EXTERNAL_DATA_LOADER_PREFIX,
+};
diff --git a/crates/re_data_source/src/lib.rs b/crates/re_data_source/src/lib.rs
@@ -15,7 +15,8 @@ mod web_sockets;
 mod load_stdin;
 
 pub use self::data_loader::{
-    iter_loaders, ArchetypeLoader, DataLoader, DataLoaderError, LoadedData, RrdLoader,
+    iter_external_loaders, iter_loaders, ArchetypeLoader, DataLoader, DataLoaderError, LoadedData,
+    RrdLoader,
 };
 pub use self::data_source::DataSource;
 pub use self::load_file::load_from_path_contents;