Skip to content

Commit

Permalink
Replace reqwest with ureq (#1407)
Browse files Browse the repository at this point in the history
* Replace reqwest with ureq for less dependencies

* Simplify code

* Cleanup
  • Loading branch information
emilk committed Mar 2, 2023
1 parent c8502d7 commit 802923c
Show file tree
Hide file tree
Showing 9 changed files with 237 additions and 83 deletions.
195 changes: 164 additions & 31 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ polars-core = "0.27.1"
polars-lazy = "0.27.1"
polars-ops = "0.27.1"
puffin = "0.14"
reqwest = { version = "0.11", default-features = false } # TODO(emilk): consider replacing `reqwest` with `ureq`
thiserror = "1.0"
time = "0.3"
tokio = "1.24"
Expand Down
4 changes: 3 additions & 1 deletion crates/re_analytics/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ uuid = { version = "1.1", features = ["serde", "v4", "js"] }

[target.'cfg(not(target_arch = "wasm32"))'.dependencies]
directories-next = "2"
reqwest = { workspace = true, features = ["blocking", "rustls-tls"] }
ureq = { version = "2.6", features = [
"json",
] } # TODO(emilk): use ehttp for web supprt

[target.'cfg(target_arch = "wasm32")'.dependencies]
web-sys = { version = "0.3.58", features = ["Storage"] }
Expand Down
3 changes: 0 additions & 3 deletions crates/re_analytics/src/pipeline_native.rs
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ pub enum PipelineError {

#[error(transparent)]
Serde(#[from] serde_json::Error),

#[error(transparent)]
Http(#[from] reqwest::Error),
}

/// An eventual, at-least-once(-ish) event pipeline, backed by a write-ahead log on the local disk.
Expand Down

0 comments on commit 802923c

Please sign in to comment.