Skip to content

Commit

Permalink
old me just proved that it all works as expected
Browse files Browse the repository at this point in the history
  • Loading branch information
teh-cmc committed Jul 7, 2023
1 parent e3513b4 commit 8d3c9c2
Show file tree
Hide file tree
Showing 3 changed files with 1,476 additions and 1,490 deletions.
16 changes: 1 addition & 15 deletions crates/re_sdk/src/recording_stream.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1144,21 +1144,7 @@ mod tests {
_ => panic!("expected SetStoreInfo"),
}

// The underlying batcher is never flushing: there's nothing else.
assert!(msgs.pop().is_none());
}

// The underlying batcher is never flushing: there's nothing else.
assert!(storage.take().is_empty());

rec_stream.flush_blocking(); // flush the entire hierarchy

{
let mut msgs = {
let mut msgs = storage.take();
msgs.reverse();
msgs
};
// MemorySinkStorage transparently handles flushing during `take()`!

// The batched table itself, which was sent as a result of the explicit flush above.
match msgs.pop().unwrap() {
Expand Down

0 comments on commit 8d3c9c2

Please sign in to comment.