Skip to content

Commit

Permalink
Lint fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
emilk committed Mar 22, 2023
1 parent 3b01e8d commit 9901e7c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion crates/re_log/src/multi_logger.rs
Expand Up @@ -6,7 +6,7 @@ static MULTI_LOGGER: MultiLogger = MultiLogger::new();

static HAS_MULTI_LOGGER: AtomicBool = AtomicBool::new(false);

/// Produced when trying to install additional loggers when [`init`] has not been called.
/// Produced when trying to install additional loggers when [`crate::setup_native_logging`] has not been called.
///
/// This can happen for example when users of the `rerun` crate use the `spawn` method,
/// and they aren't using `re_log`.
Expand Down
2 changes: 1 addition & 1 deletion crates/re_viewer/src/remote_viewer_app.rs
Expand Up @@ -77,7 +77,7 @@ impl RemoteViewerApp {
self.app = Some((connection, app));
}
Err(err) => {
re_log::error!("Failed to connect to {:?}: {}", self.url, err);
re_log::error!("Failed to connect to {:?}: {err}", self.url);
}
}
}
Expand Down

1 comment on commit 9901e7c

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust Benchmark

Benchmark suite Current: 9901e7c Previous: 3b01e8d Ratio
datastore/insert/batch/rects/insert 563454 ns/iter (± 4845) 569830 ns/iter (± 5333) 0.99
datastore/latest_at/batch/rects/query 1857 ns/iter (± 48) 1859 ns/iter (± 2) 1.00
datastore/latest_at/missing_components/primary 287 ns/iter (± 1) 302 ns/iter (± 2) 0.95
datastore/latest_at/missing_components/secondaries 437 ns/iter (± 2) 448 ns/iter (± 0) 0.98
datastore/range/batch/rects/query 149290 ns/iter (± 1139) 149722 ns/iter (± 996) 1.00
mono_points_arrow/generate_message_bundles 43609337 ns/iter (± 885437) 44628851 ns/iter (± 2651533) 0.98
mono_points_arrow/generate_messages 124759779 ns/iter (± 1189980) 125359619 ns/iter (± 1509549) 1.00
mono_points_arrow/encode_log_msg 153567144 ns/iter (± 711968) 157053209 ns/iter (± 1184160) 0.98
mono_points_arrow/encode_total 327263578 ns/iter (± 1352920) 329909462 ns/iter (± 1872551) 0.99
mono_points_arrow/decode_log_msg 174877558 ns/iter (± 860106) 172445624 ns/iter (± 2781824) 1.01
mono_points_arrow/decode_message_bundles 63007452 ns/iter (± 929547) 61554500 ns/iter (± 1003531) 1.02
mono_points_arrow/decode_total 235272471 ns/iter (± 1431107) 228444437 ns/iter (± 2630599) 1.03
batch_points_arrow/generate_message_bundles 337269 ns/iter (± 769) 325330 ns/iter (± 4377) 1.04
batch_points_arrow/generate_messages 6406 ns/iter (± 15) 6255 ns/iter (± 99) 1.02
batch_points_arrow/encode_log_msg 369890 ns/iter (± 979) 368027 ns/iter (± 4932) 1.01
batch_points_arrow/encode_total 727174 ns/iter (± 2359) 712689 ns/iter (± 14803) 1.02
batch_points_arrow/decode_log_msg 349355 ns/iter (± 875) 347837 ns/iter (± 2897) 1.00
batch_points_arrow/decode_message_bundles 2129 ns/iter (± 11) 2030 ns/iter (± 16) 1.05
batch_points_arrow/decode_total 355917 ns/iter (± 714) 345291 ns/iter (± 3389) 1.03
arrow_mono_points/insert 6151564119 ns/iter (± 12179130) 6108385565 ns/iter (± 145421851) 1.01
arrow_mono_points/query 1766371 ns/iter (± 11900) 1789657 ns/iter (± 31119) 0.99
arrow_batch_points/insert 2662872 ns/iter (± 25356) 2639933 ns/iter (± 56891) 1.01
arrow_batch_points/query 16144 ns/iter (± 116) 16209 ns/iter (± 17) 1.00
arrow_batch_vecs/insert 42411 ns/iter (± 317) 42480 ns/iter (± 84) 1.00
arrow_batch_vecs/query 387146 ns/iter (± 3875) 388406 ns/iter (± 334) 1.00
tuid/Tuid::random 34 ns/iter (± 0) 34 ns/iter (± 0) 1

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.