Skip to content

Commit

Permalink
Fix crate isolation build issues (#6362)
Browse files Browse the repository at this point in the history
* [x] I know how to trick the checkbox CI
  • Loading branch information
Wumpf committed May 16, 2024
1 parent 838eab1 commit c68ea30
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion crates/re_log_types/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ pub struct StoreInfo {
///
// NOTE: The version comes directly from the decoded RRD stream's header, duplicating it here
// would probably only lead to more issues down the line.
#[serde(skip)]
#[cfg_attr(feature = "serde", serde(skip))]
pub store_version: Option<CrateVersion>,
}

Expand Down
1 change: 1 addition & 0 deletions crates/re_viewer/src/app.rs
Original file line number Diff line number Diff line change
Expand Up @@ -983,6 +983,7 @@ impl App {
format!("Data source {} has left unexpectedly: {err}", msg.source);

#[cfg(not(target_arch = "wasm32"))]
#[cfg(feature = "server")]
if err
.downcast_ref::<re_sdk_comms::ConnectionError>()
.is_some_and(|e| {
Expand Down
1 change: 1 addition & 0 deletions rerun_py/build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ fn main() {
&& !re_build_tools::is_tracked_env_var_set("RERUN_ALLOW_MISSING_BIN")
{
#[cfg(target_os = "windows")]
#[allow(clippy::unwrap_used)]
let rerun_bin = std::env::current_dir()
.unwrap()
.join("rerun_sdk/rerun_cli/rerun.exe");
Expand Down

0 comments on commit c68ea30

Please sign in to comment.