clean up

crates/re_data_source/src/data_loader/mod.rs

@@ -10,7 +10,7 @@ use re_log_types::{ArrowMsg, DataRow, EntityPath, LogMsg, TimePoint};
 ///
 /// The loader is free to ignore some or all of these.
 ///
-/// External [`DataLoader`]s will be passed the the following CLI parameters:
+/// External [`DataLoader`]s will be passed the following CLI parameters:
 /// * `--recording-id <store_id>`
 /// * `--opened-recording-id <opened_store_id>` (if set)
 /// * `--entity-path-prefix <entity_path_prefix>` (if set)
@@ -27,7 +27,7 @@ pub struct RecommendedLoadSettings {
     /// Log data to this recording if you want it to appear in a new recording shared by all
     /// data-loaders for the current loading session.
     //
-    // TODO: issue
+    // TODO(#5350): actually support this
     pub opened_store_id: Option<re_log_types::StoreId>,
 
     /// What should the entity paths be prefixed with?

crates/re_data_source/src/load_file.rs

@@ -36,7 +36,7 @@ pub fn load_from_path(
 
     let data = load(settings, path, None)?;
 
-    // TODO: there's probably gonna be issues with this though... maybe?
+    // TODO(cmc): should we always unconditionally set store info though?
     // If we reach this point, then at least one compatible `DataLoader` has been found.
     let store_info = prepare_store_info(&settings.store_id, file_source, path);
     if let Some(store_info) = store_info {
@@ -45,7 +45,6 @@ pub fn load_from_path(
         }
     }
 
-    // TODO: should we be using this one here?
     send(&settings.store_id, data, tx);
 
     Ok(())
@@ -73,6 +72,7 @@ pub fn load_from_file_contents(
 
     let data = load(settings, filepath, Some(contents))?;
 
+    // TODO(cmc): should we always unconditionally set store info though?
     // If we reach this point, then at least one compatible `DataLoader` has been found.
     let store_info = prepare_store_info(&settings.store_id, file_source, filepath);
     if let Some(store_info) = store_info {
@@ -81,7 +81,6 @@ pub fn load_from_file_contents(
         }
     }
 
-    // TODO: should we be using this one here?
     send(&settings.store_id, data, tx);
 
     Ok(())

examples/rust/external_data_loader/src/main.rs

@@ -83,7 +83,7 @@ fn main() -> anyhow::Result<()> {
         rec.stdout()?
     };
 
-    // TODO: send APIs
+    // TODO(#3841): really need those send APIs
     rec.set_timepoint(timepoint_from_args(&args)?);
 
     let entity_path_prefix = args