Skip to content

Commit

Permalink
Use einops for clarity when rearranging
Browse files Browse the repository at this point in the history
  • Loading branch information
nikolausWest committed Jan 31, 2023
1 parent ef08215 commit e3885a8
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion examples/colmap/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from pathlib import Path
from typing import Any, Final

from einops import rearrange
import numpy as np
import numpy.typing as npt
import requests
Expand Down Expand Up @@ -88,7 +89,7 @@ def read_and_log_sparse_reconstruction(dataset_path: Path, filter_output: bool)
# Iterate through images (video frames) logging data related to each frame.
for image in sorted(images.values(), key=lambda im: im.name): # type: ignore[no-any-return]
frame_idx = int(image.name[0:4]) # COLMAP sets image ids that don't match the original video frame
quat_xyzw = image.qvec[[1, 2, 3, 0]] # COLMAP uses wxyz quaternions
quat_xyzw = rearrange(image.qvec, "z x y z -> x y z w")
camera_from_world = (image.tvec, quat_xyzw) # COLMAP's camera transform is "camera from world"
camera = cameras[image.camera_id]
intrinsics = intrinsics_for_camera(camera)
Expand Down

0 comments on commit e3885a8

Please sign in to comment.